Page MenuHomePhabricator
Create Task
Maniphest T36762

Patching DatabaseMysql.php's close to meet specification
Closed, ResolvedPublic
Actions

Description

Resetting mConn upon closing MySQL database connection

The documentation of the close function in includesDatabase.php:730--736 says that 'close' should return true, when called for an already closed connection.

Calling close on an already closed DatabaseMysql object fails, by something like:
-----8<------
PHP Warning: mysql_close(): 4 is not a valid MySQL-Link resource in /home/christian/sources/Wikimedia/shreddingPHPUnit/dummy.php on line 13

Warning: mysql_close(): 4 is not a valid MySQL-Link resource in /home/christian/sources/Wikimedia/shreddingPHPUnit/dummy.php on line 13
-----8<------

The problem seems to be that mConn is not cleared upon closing DatabaseMysql.

The attached patch resolves this issue.

Version: 1.20.x
Severity: normal

Attached:

Resetting-mConn-upon-closing-MySQL-database-connecti.patch575 BDownload

Details

Reference
bz34762

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:18 AM
• bzimport added a project: MediaWiki-libs-Rdbms.
• bzimport set Reference to bz34762.
• bzimport added a subscriber: Unknown Object (MLST).
QChris created this task.Feb 27 2012, 9:00 PM
MarkAHershberger added a comment.Feb 28 2012, 2:10 AM

Why would you call ->close() twice anyway? It seems like that is the bug that should be fixed.

• demon added a comment.Feb 28 2012, 2:19 AM

Fixed in r112565 for all DatabaseBase subclasses (except Sqlite, which wasn't affected).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL