Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate all the required settings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Feb 29 2012, 1:46 AM

Description

Author: damian

Description:
Diff of changes

The current sanity check which ensures that the wgLDAPAutoAuthUsername variable is set to something doesn't ensure that the wgLDAPAutoAuthDomain is set to something.

If the wgLDAPAutoAuthDomain is not set and the hook is loaded, when the auth call runs it ends up generating a php warning and no debug output.

The attached patch resolves the issue.

Version: unspecified
Severity: minor

Attached:

LDAPAuth.patch355 BDownload

Details

Reference: bz34787

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:10 AM

• bzimport added a project: MediaWiki-extensions-LdapAuthentication.

• bzimport set Reference to bz34787.

• bzimport created this task.Feb 29 2012, 1:46 AM

damian wrote:

https://gerrit.wikimedia.org/r/#/c/21309/

damian wrote:

Change merged.

That change is broken. Please see inline comments.

damian wrote:

Oops, fix in https://gerrit.wikimedia.org/r/22615.

Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate all the required settingsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate all the required settings
Closed, ResolvedPublic
Actions