Page MenuHomePhabricator

[Regression] User name should be normalized on Special:Contributions
Closed, ResolvedPublic

Description

Since the update to 1.19 there are several bugs due to missing normalization of the name on Special:Contributions

  • Using entities causes a server error (see URL, or just enter Ä as user name)
  • Leading whitespace before IPs is not removed, compare [[Special:Contributions/93.157.221.6]] (edits are shown) and [[Special:Contributions/ 93.157.221.6]] (no edits)

Version: 1.19
Severity: normal
URL: https://en.wikipedia.org/w/index.php?limit=50&tagfilter=&title=Special%3AContributions&contribs=user&target=%26Auml%3B&namespace=&tagfilter=&year=&month=-1

Details

Reference
bz34889

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:17 AM
bzimport set Reference to bz34889.

Special:Contributions is usingn User::newFromName( $target, false ); since r103751, but that method does not do title normalisation like stripping leading/trailing whitespaces for parameter "false", but without false ips does not work.

a.d.bergi wrote:

see also http://de.wikipedia.org/w/index.php?diff=100334303&oldid=100333981

...or ignore it, most of it is about template synatx and urlencoded wikilinks (working as usual).

Interesting comment: it worked in 1.18, compare
http://zh.wikipedia.org/wiki/Special:Contribs/111.252.33.110?uselang=en to
http://zh.wikipedia.org/wiki/Special:Contribs/_111.252.33.110?uselang=en

(In reply to comment #2)

Special:Contributions is usingn User::newFromName( $target, false ); since
r103751, but that method does not do title normalisation like stripping
leading/trailing whitespaces for parameter "false", but without false ips does
not work.

Assigning to Roan then :)