Page MenuHomePhabricator

jquery.client.js should recognize rekonq correctly
Closed, ResolvedPublic

Description

[[rekonq]] is currently recognized as Safari 2.0. This is due to the strange treatment of Safari version numbers [1].

This is a real issue, since WikiEditor refuses to work in browsers recognized as Safari 2.0. As rekonq will become more important, this should be fixed as soon as possible.

A typical value of navigator.userAgent is
Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.34 (KHTML, like Gecko) rekonq Safari/534.34

[1] https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.client.js?revision=94389&view=markup#l137


Version: 1.18.x
Severity: normal

Details

Reference
bz34924

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:20 AM
bzimport set Reference to bz34924.

Trevor (tparscal) said he could add workarounds for this, so ping him if you really need this.

This should be solve in r113105 based on testing with the user agent string supplied in this bug. Now WikiEditor won't mistake this browser for Safari 2.0. That doesn't mean this browser is compatible with WikiEditor magically though, and based on their inability to create a reasonable user agent string for their browser this may not be the last we hear of this. :(

Please verify this fixes the issues.

Verified by the unit test and live via the rekonq browser on Roan's computer.

Just to note it down: This changed the accesskey displayed in the tooltip from Alt-Shift to Alt, but since both work this doesn't matter.
[https://de.wikipedia.org/w/index.php?oldid=100597992#Vector-Bearbeitungsleiste_auch_f.C3.BCr_rekonq]