Page MenuHomePhabricator

[Regression] IRC action text should never contain HTML for title
Closed, ResolvedPublic

Description

Although bug 34508 was fixed and many actions have been hardcoded to be fixed, there is still an issue with log actions registered by extensions.

However it's a different bug than bug 34508. The problem is not the format of the message. Wether the i18n message key is the same or not is not in the question here.

The problem is that the logging system is replacing variables with an HTML link instead of a bracketed wiki link for the target title.

Reporting in core instead of CentralAuth since this should be fixed centrally, not by hardcoding an exception for centralauth.

<rc-pmtpa> [[Special:Log/gblrights]] setchange * Dungodung * changed wikis in "<a href="/wiki/Special:WikiSets/12" title="Special:WikiSets/12">All existing wikis</a>": added: (none); removed: chwikimedia: -chwikimedia


Version: unspecified
Severity: critical

Details

Reference
bz34980

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:12 AM
bzimport set Reference to bz34980.

Fixed in r114151; this was a regression from r106782 (last chunk of CentralAuth.php). Core behaviour did not change, so I'm putting this bug back in MediaWiki extensions/CentralAuth.

  • Bug 42851 has been marked as a duplicate of this bug. ***

(In reply to comment #0)

Reporting in core instead of CentralAuth since this should be fixed
centrally,
not by hardcoding an exception for centralauth.

Is this still valid? If yes, it should be reopened because there are other instances like bug 42851.