Page MenuHomePhabricator

<ref> doesn't expand triple-brace template parameters
Closed, DuplicatePublic

Description

Originally reported here: https://www.mediawiki.org/w/index.php?title=Project:Support_desk&offset=20120306025209#using_urls_in_cite.php_12728

Given something like <ref>{{{foo}}}</ref>, the {{{foo}}} should be expanded with the content of the foo template parameter if applicable.

Basically all that needs to be done is add the PPFrame given as an argument to the <ref> callback as the second argument to the recursiveTagParse calls.


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:14 AM
bzimport set Reference to bz34999.
bzimport added a subscriber: Unknown Object (MLST).

Possibly related: bug 31374 comment 23.

I also imagine this bug is a dupe, but perhaps not.

(In reply to comment #1)

Possibly related: bug 31374 comment 23.

Yes, you can use #tag as a work around.

I also imagine this bug is a dupe, but perhaps not.

I searched, but couldn't find one.

Duplicate of bug 24160, which is a duplicate of bug 2700.

  • This bug has been marked as a duplicate of bug 2700 ***

(In reply to comment #3)

Duplicate of bug 24160, which is a duplicate of bug 2700.

  • This bug has been marked as a duplicate of bug 2700 ***

triple brace expansion isn't done during PST. Re-opening.

gerrit change 14682.

However, I've never seen anyone else use replaceVariables in the way i did in that change, so we'll see if it passes review or not...

sumanah wrote:

The Gerrit patch was abandoned in August so this is free for the taking. :-)

It would be easier to just use {{#tag:ref| {{{foo}}} }} ...

aalekh1993 wrote:

Hi i am new to mediawiki can this bug be assigned to me i am really passionate about contributing to mediawiki....Thanks

Change 104794 had a related patch set uploaded by AalekhN:
Made Changes as per Bug 34999 <ref>{{{foo}}}</ref> is working on the local machine

https://gerrit.wikimedia.org/r/104794

Hi Aalekh, the patch needs some rework, see the comments in Gerrit - would you be willing to work on it?

aalekh1993 wrote:

Yes sir I will try my best to solve the bug as soon as possible

Change 104794 had a related patch set uploaded (by Paladox):
Made Changes as per Bug T36999 <ref>{{{foo}}}</ref> is working on the local machine....also added some changes after review by Bawolff

https://gerrit.wikimedia.org/r/104794

Change 104794 abandoned by Thiemo Kreuz (WMDE):
Made Changes as per Bug T36999 <ref>{{{foo}}}</ref> is working on the local machine....also added some changes after review by Bawolff

Reason:
This patch is very old, and still incomplete since then. The Phabricator ticket is still open. It looks like it's a more generic problem not specific to this extension.

https://gerrit.wikimedia.org/r/104794