Page MenuHomePhabricator

UploadFromStash is broken in 1.18.1
Closed, ResolvedPublic

Description

UploadFromStash is broken in MediaWiki 1.18.1.
So when you try uploading a file and it fails with a warning (for example ...this file is a duplicate of...), clicking both "Submit modified file description" and "Ignore warning and save file anyway" buttons don't work - you just get an empty upload form after it.
This bug can be fixed by taking includes/upload/UploadFromStash.php and includes/upload/UploadStash.php from trunk r105822.
Marking this bug major as MediaWiki 1.18.1 is listed as stable. The fix probably needs queueing for 1.18.2.


Version: 1.18.x
Severity: major

Details

Reference
bz35032

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:16 AM
bzimport set Reference to bz35032.
bzimport added a subscriber: Unknown Object (MLST).

If you can provide a patch for this we'll look at merging it for a
1.18.2 tarball.

andy wrote:

Thanks for posting this here. This fixed my problem.

(In reply to comment #1)

If you can provide a patch for this we'll look at merging it for a
1.18.2 tarball.

It can just be done now, then it's there if/when we have a 1.18.2 release. Saves scrambling around looking for these bugs in the run up to release =)

(In reply to comment #0)

This bug can be fixed by taking includes/upload/UploadFromStash.php and
includes/upload/UploadStash.php from trunk r105822.
Marking this bug major as MediaWiki 1.18.1 is listed as stable. The fix
probably needs queueing for 1.18.2.

Although maybe the easiest way, blindly copying from trunk doesn't sounds like the best way..

Done in r113481

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM