Page MenuHomePhabricator

[Regression] Don't prepend 2 empty lines before the Welcome template
Closed, ResolvedPublic

Description

The extension prepends an empty line before the template, twice.

  • One: Presumably in case there is content on the page already, however the extension doesn't reach this code in that case since it returns early if $talk->exists(), and even then, it should only insert the new line in case it exists at point of saving).
  • One: To create space between the (optional!) subject header.

This is also causing a visual gap on top of the user talk page:

Example:

Proposing to:

  • Move the first newline to where it detects the page already exists, away from the all-case that in (so far) 100% cases is never reached, fixing the first new line
  • Move the second new line to within the if(subject) block, fixing the second one.

Version: unspecified
Severity: normal

Details

Reference
bz35058