Page MenuHomePhabricator

Pending changes diff is centered
Closed, ResolvedPublic

Description

Author: alexsm333

Description:
Pending changes (collapsed) diff is centered

"Pending changes diff" text is centered (see the attachment).

To recreate the problem:

  • have editor flag
  • check "Show the pending changes diff when viewing the latest pending revision" in preferences
  • visit any page with pending changes and click "show those changes"

Depending on how you get to the page the diff table is inside either div.flaggedrevs_preview or div.flaggedrevs_basic both of which have "text-align:center" in ext.flaggedRevs.basic.css

As a temporary workaround we had to add this to ru:MediaWiki:Common.css:
#mw-fr-stablediff {text-align: left}


Version: unspecified
Severity: normal

Attached:

pending_changes_diff_-_centered.png (226×908 px, 9 KB)

Details

Reference
bz35202

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:17 AM
bzimport set Reference to bz35202.
bzimport added a subscriber: Unknown Object (MLST).

alexsm333 wrote:

  1. It's plain inconvenient: the text in NOT centered in any other diffs.
  1. It's a regression from MW 1.18.
  1. It doesn't respect "justify paragraphs" option in preferences.

I can't find any FR changes to cause this, so it must have been some side-effect of a core change.