Page MenuHomePhabricator

take over jquery.tipsy plugin
Closed, ResolvedPublic

Description

From my comment on bug 33562:

I guess upstream author abandoned or lost interest into the project. Despite 29
pull requests and several mails sent to his various email addresses, I have not
heard back from him.

I think we should take over the project and fork it under the wikimedia team on
Github. Merge the pull requests, include our changes. Then release a new
version making it clear we are taking over the project.


Version: unspecified
Severity: enhancement

Details

Reference
bz35241

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:09 AM
bzimport set Reference to bz35241.

We could either host it:

agree 100%.

the only other sane option is to switch from tipsy and find another, maintained, plugin that provides this functionality.

i was not aware of these 29 pull requests - they should be handled very carefully.
with high probability not all are good and some provide overlapping functionality.

peace.

this is actually somewhat important - as mentioned in Bug #35212, tipsy contains few bugs (both the mediawiki version and the upstream head version). we should either take responsibility for this cute plugin, or find some maintained package to provide this functionality.

i attached a version that deals with the bugs known to me to #35212, but it's not thoroughly tested.

peace.

(In reply to comment #3)

this is actually somewhat important - as mentioned in Bug #35212, tipsy
contains few bugs (both the mediawiki version and the upstream head version).

Bumping priority.

Any news about this issue?

peace.

Still no news from upstream and I personally don't have anytime to handle this issue. This is most probably something that will need to be done by the WMF feature team.

I have asked internally Tomasz Finc to have a new github repository created under https://github.com/wikimedia .

The fork is now at https://github.com/wikimedia/jquery-tipsy with pull requests and issue tracker enabled. WMF staff should have read write access provided they are part of the wikimedia github team.

Thanks to Tomasz Finc for the fork help!

Did any work happen in the fork? From the github network graph it seems it is still identical to the original tipsy plugin; there is a semi-maintained fork under https://github.com/CloCkWeRX/tipsy which has lots of fixes applied.

(In reply to Tisza Gergő from comment #9)

Did any work happen in the fork? From the github network graph it seems it
is still identical to the original tipsy plugin; there is a semi-maintained
fork under https://github.com/CloCkWeRX/tipsy which has lots of fixes
applied.

I don't think we did anything on the forked repository beside some linting as shown at:

https://github.com/wikimedia/jquery-tipsy/commits/master

Our fork is really the code from mediawiki/core source code.

What could be done is:

  • upstream mediawiki core changes to our repo wikimedia/jquery-tipsy
  • triage / integrate pull requests from upstream https://github.com/jaz303/tipsy/pulls and integrate them in our fork
  • whenever we have something nice/robust, cut a new release of the fork and update the version we have in mediawiki/core

That would be the open source way of doing things. I am not sure we have any interest in maintaining jquery-tipsy though. That is probably superseded by ooui.

Upstream author never replied to my mails and apparently gave up maintaining his repository.