Page MenuHomePhabricator
Create Task
Maniphest T37352

Getting zero related data charge warnings on the regular mobile site
Closed, ResolvedPublic
Actions

Description

Author: afeldman

Description:
When using en.m.wikipedia.org from my iphone, clicking an image takes me to an imageless page with a "Data charges may apply if you continue" banner.

This is only supposed to be shown on zero, and only on select carriers that aren't zero rating images. This is supposed to be determined by the value of the X-Carrier header which is set by varnish via ip acls but I don't see any use of that header in the deployed or trunk versions of MobileFrontend.

Version: .5
Severity: normal

Details

Reference
bz35352

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:18 AM
• bzimport added a project: Wikimedia-Mobile-Generic.
• bzimport set Reference to bz35352.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 20 2012, 7:32 AM
Jdlrobson added a comment.Mar 20 2012, 8:02 AM

Created attachment 10287
Only enables zero rated on file page when $renderZeroRatedBanner set

Attached:

35352.diff721 BDownload

• Tfinc added a comment.Mar 20 2012, 8:58 AM

Changes checked in and are preilly approved. This has now been deployed to production.

Issues is resolved minus some old cached file desc pages.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL