Page MenuHomePhabricator

VisualEditor: behavior switches are saved in parser environment
Closed, DeclinedPublic

Description

parser patch to stub signature wikitext

Just learning about the parser--these patches will match the NOTOC etc. layout behavior switch keywords, and signature and timestamp strings.

I'm not so confident about my decisions where to put these grammars.

The behavior switch keywords should probably turn into tokens which send control commands to set state in the sync23 stage.

The signature doesn't have access to the current username. The timestamp has no locale or user timezone functionality.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz35392

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:09 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz35392.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 10309
parser grammar stub for behavior switch magic words

Attached:

Patches have been deprecated in favor of https://gerrit.wikimedia.org/r/4050

I've abandoned the signature/timestamp patch, agreeing with Brion that,

These sorts of things really should be happening *in* the editor, rather
than in the parser. We only have to put ~~~~ in because the original editor
was too primitive to have a nice "insert signature" live function. So I
think it's worth really rethinking how these things get done for the new
paradigm. :)

Mass-moving items into VisualEditor product

Seems to be a NOTDONE given Adam's comment. :-)