Page MenuHomePhabricator

[Regression] Special:Log/patrol doesn't show "(automatic)" for autopatrols anymore
Closed, ResolvedPublic

Description

Compare for example

Although autopatrol isn't a distinct log_action/log_type, they are detectable when iterating over rows with the log_params/comment information. Up until 1.19 this was also reported in the log, but now is no longer.

This is affecting patrollers on wikis with rcpatrol.


Version: 1.19
Severity: major

Details

Reference
bz35565

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:11 AM
bzimport set Reference to bz35565.
bzimport added a subscriber: Unknown Object (MLST).

It should still work, it has just been reworded:
'logentry-patrol-patrol' => '$1 marked revision $4 of page $3 patrolled',
'logentry-patrol-patrol-auto' => '$1 automatically marked revision $4 of page $3 patrolled'

Sorry to say, but no, it's still not fixed. Take for example the patrol log of MoiraMoira (another Dutch admin): https://nl.wikipedia.org/w/index.php?title=Speciaal:Logboeken&type=patrol&user=MoiraMoira&uselang=en - I don't see the word "automatic" anywhere...

When things are fixed in source control, they don't magically get deployed to cluter, wait a little.

As of 1.19.3, this still hasn't been incorporated.

(In reply to comment #6)

As of 1.19.3, this still hasn't been incorporated.

This bug was fixed in March 2012 and first released in v1.20.0. It was deployed in wmf/1.20wmf1

It will not be back ported to v1.19 at this time since v1.19 is on legacy support and this probably won't be enough for a follow-up release (v1.21 has already been released, v1.22 is under development).

(In reply to comment #4)

Sorry to say, but no, it's still not fixed. Take for example the patrol log
of
MoiraMoira (another Dutch admin):
https://nl.wikipedia.org/w/index.php?title=Speciaal:
Logboeken&type=patrol&user=MoiraMoira&uselang=en

  • I don't see the word "automatic" anywhere...

18:20, 7 June 2013 MoiraMoira (..)

automatically marked revision 37912636 of page .. patrolled

18:17, 7 June 2013 MoiraMoira (..)

automatically marked revision 37912623 of page .. patrolled

18:16, 7 June 2013 MoiraMoira (..)

automatically marked revision 37912617 of page .. patrolled

15:15, 7 June 2013 MoiraMoira (..)

marked revision 37911385 of page .. patrolled

It does now :)

For any 1.19 users out there, I've just finished porting the changes from the link in comment 3 and they work fine.