Page MenuHomePhabricator

Watchlist doesn't show or count pages not in the main namespace when deleting them from the watchlist
Closed, ResolvedPublic

Description

On removing 8-9 titles from my watchlist, I got the following message:

6 titles were removed from your watchlist:
Andrew Kenyon-Smith (talk)
Ben Knapp (talk)
Jakob Ullmann (talk)
Ji Hyunwoo (talk)
Phil Murray (talk)
Top Dogg (talk)

which should be:

8 (or 9) titles were removed from your watchlist:
Andrew Kenyon-Smith (talk)
Ben Knapp (talk)
Jakob Ullmann (talk)
Ji Hyunwoo (talk)
Phil Murray (talk)
Top Dogg (talk)
<whatever> (talk)
<whatever> (talk)
<whatever> (talk)

I have been experiencing this from a long time. But they were removed all right.


Version: unspecified
Severity: minor

Details

Reference
bz35601

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:13 AM
bzimport set Reference to bz35601.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been confirmed by popular vote. ***

Confirmed. Looks like it isn't counting pages that are not in the main namespace.

javaron wrote:

possible patch

This should do the trick - feedback is appreciated as I'm still new to MediaWiki development.

Attached:

sumanah wrote:

Adding the "patch" and "need-review" keywords so experienced developers know that this patch awaits review.

Also, Aaron, you can easily get developer access https://www.mediawiki.org/wiki/Developer_access and then you can submit this as a git commit right into our source control system: https://www.mediawiki.org/wiki/Git/Workflow

Thanks for the patch!

Reopening as fix not merged yet. Current patch on gerrit looks a bit overkill, it only needs to use array_merge() in one line I think.