Page MenuHomePhabricator
Create Task
Maniphest T37912

Jenkins: Set up PHPUnit testing on MySQL backend
Closed, ResolvedPublic
Actions

Description

Currently, we run the PHPUnit test suite using the SQLite backend using Jenkins upon committing code into core.

However, Wikimedias's setup relies on MySQL and MySQL is also MediaWiki's suggested DBMS.

Hence, it would be great to have Jenkins additionally run the PHPUnit test suite using the MySQL backend.

P.S.: A similar bug is said to exist in bugzilla—however, I could not find such a bug.

Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45194

Details

Reference
bz35912
SubjectRepoBranchLines +/-
Migrate prepare-mediawiki to MySQL (affects testextension + mwext-qunit)integration/configmaster+6 -5
mw-phpunit-composer, mw-extensions, integration-phpunit: sqlite > mysyqlintegration/configmaster+11 -11
mediawiki-phpunit-{phpflavour}: Use mysql instead of sqliteintegration/configmaster+3 -3
mwext-{name}-qunit: To hhvm/karma/chromium from zend/php53/phantomjsintegration/configmaster+0 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:14 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz35912.
• bzimport added a subscriber: Unknown Object (MLST).
QChris created this task.Apr 12 2012, 2:02 PM
QChris added a comment.Apr 12 2012, 2:06 PM
  • This bug has been confirmed by popular vote. ***
ArielGlenn added a comment.Apr 12 2012, 2:47 PM

fwiw I would love to see this happen, given that WMF's production (and labs) backend is MySQL and not SQLite.

scfc added a comment.Oct 4 2012, 12:00 PM

Any update on this?

ori added a comment.Feb 24 2013, 6:50 PM

Could someone provide examples of the sort of bugs or crashes that would have been caught by using MySQL as the back-end for the unit tests?

• Mattflaschen-WMF added a comment.May 23 2013, 12:03 AM

There are a couple cases I'm aware of with using SQLite:

  1. The math extension can not run all of its tests, since SQLite has global indices. See https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Math.git;a=blob;f=tests/MathDatabaseTest.php;h=f909f7f20cdcf7814d2ac9c08bc777c25401e764;hb=refs/heads/master#l86 . Judging by that comment, all other databases including MySQL work.
  2. Similarly, Echo had an issue since SQLite doesn't have "ALTER TABLE CHANGE" (https://gerrit.wikimedia.org/r/#/c/64594/).

Of course, it's preferable to support multiple databases, including SQLite if possible. But it would be very useful to also test in MySQL both because the behavior can differ, and because SQLite sometimes just doesn't work for what we currently need.

hashar added a comment.May 23 2013, 9:25 AM

Since I started working on CI we always wanted to test against different database backend. I am not sure the full test suite is really needed, but we should at least run the installer, that will most probably catch up the commons issues.

hashar added a comment.Dec 2 2013, 12:58 PM

Not a priority

hashar lowered the priority of this task from Low to Lowest.Nov 24 2014, 11:52 AM
hashar set Security to None.
Krinkle moved this task from Untriaged to Next on the Continuous-Integration-Infrastructure board.Mar 2 2015, 3:02 PM
greg raised the priority of this task from Lowest to Medium.Mar 2 2015, 5:14 PM
greg subscribed.

Changing priority: testing on top of the software we use in production is a good thing.

MarkAHershberger unsubscribed.Mar 3 2015, 3:28 PM
• Mattflaschen-WMF added a project: Wikimedia-Hackathon-2015.Mar 5 2015, 11:53 PM
• Mattflaschen-WMF moved this task from Backlog to Hacking proposals on the Wikimedia-Hackathon-2015 board.
Krinkle mentioned this in T89180: Jenkins jobs using MediaWiki frequently fail due to database locks .Mar 18 2015, 4:35 PM
Krinkle mentioned this in T57788: Jenkins: Create shell wrapper to setup MySQL database.Mar 20 2015, 8:22 AM
Krinkle closed subtask T57788: Jenkins: Create shell wrapper to setup MySQL database as Resolved.
Krinkle mentioned this in T93442: Add support for Sqlite.Mar 20 2015, 10:18 PM
Krinkle claimed this task.Mar 20 2015, 11:02 PM
Krinkle moved this task from Next to In-progress on the Continuous-Integration-Infrastructure board.
Krinkle removed a project: Wikimedia-Hackathon-2015.
Krinkle removed a subscriber: Unknown Object (MLST).

Acting on this ahead of Wikimedia-Hackathon-2015 due to SQLite issues and MySQL being the interim solution for it.

gerritbot subscribed.Mar 20 2015, 11:06 PM

Change 198293 had a related patch set uploaded (by Krinkle):
mwext-{name}-qunit: To hhvm/karma/chromium from zend/php53/phantomjs

https://gerrit.wikimedia.org/r/198293

gerritbot added a project: Patch-For-Review.Mar 20 2015, 11:06 PM
gerritbot added a comment.Mar 20 2015, 11:11 PM

Change 198293 merged by jenkins-bot:
mwext-{name}-qunit: To hhvm/karma/chromium from zend/php53/phantomjs

https://gerrit.wikimedia.org/r/198293

gerritbot added a comment.Mar 20 2015, 11:17 PM

Change 198424 had a related patch set uploaded (by Krinkle):
mediawiki-phpunit-{phpflavour}: Use mysql instead of sqlite

https://gerrit.wikimedia.org/r/198424

Krinkle mentioned this in T93458: QueryAllSpecialPagesTest for SpecialBrokenRedirects does not work on MySQL.Mar 21 2015, 12:25 AM
gerritbot added a comment.Mar 21 2015, 12:34 AM

Change 198424 merged by jenkins-bot:
mediawiki-phpunit-{phpflavour}: Use mysql instead of sqlite

https://gerrit.wikimedia.org/r/198424

gerritbot added a comment.Mar 21 2015, 12:43 AM

Change 198444 had a related patch set uploaded (by Krinkle):
mw-phpunit-composer, mw-extensions, integration-phpunit: sqlite > msyql

https://gerrit.wikimedia.org/r/198444

gerritbot added a comment.Mar 21 2015, 2:29 AM

Change 198444 merged by jenkins-bot:
mw-phpunit-composer, mw-extensions, integration-phpunit: sqlite > mysyql

https://gerrit.wikimedia.org/r/198444

Krinkle mentioned this in T93556: Unit tests using database are slower than needed.Mar 23 2015, 4:46 AM
Krinkle mentioned this in rCICF72c802f9ea45: mwext-{name}-qunit: To hhvm/karma/chromium from zend/php53/phantomjs.Mar 23 2015, 3:56 PM
Krinkle mentioned this in rCICF2957704054ea: mw-phpunit-composer, mw-extensions, integration-phpunit: sqlite > mysyql.
Krinkle mentioned this in rCICFa89607f5241f: mediawiki-phpunit-{phpflavour}: Use mysql instead of sqlite.
Krinkle removed a project: Patch-For-Review.Mar 23 2015, 5:17 PM
Krinkle removed a subscriber: gerritbot.
gerritbot added a comment.Mar 23 2015, 6:30 PM

Change 198773 had a related patch set uploaded (by Krinkle):
Migrate prepare-mediawiki to MySQL (affects testextension mwext-qunit)

https://gerrit.wikimedia.org/r/198773

gerritbot added a project: Patch-For-Review.Mar 23 2015, 6:30 PM
Krinkle closed this task as Resolved.Mar 25 2015, 3:29 AM
Krinkle moved this task from In-progress to Done on the Continuous-Integration-Infrastructure board.
gerritbot added a comment.Mar 25 2015, 3:33 AM

Change 198773 merged by jenkins-bot:
Migrate prepare-mediawiki to MySQL (affects testextension mwext-qunit)

https://gerrit.wikimedia.org/r/198773

Krinkle mentioned this in rCICF9ea777d91443: Migrate prepare-mediawiki to MySQL (affects testextension + mwext-qunit).Mar 25 2015, 3:34 AM
• Mattflaschen-WMF unsubscribed.Mar 26 2015, 11:07 PM
hashar mentioned this in T254031: Enable mediawiki-quibble-apitests-vendor-docker for extension Math.Nov 7 2020, 8:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL