Page MenuHomePhabricator

[upstream] Dependency graph points to localhost:8080
Closed, ResolvedPublic

Description

When looking at https://integration.mediawiki.org/ci/view/All/job/MediaWiki-postgres-phpunit/depgraph-view/? with Konqueror, Firefox or Chrome, the link in the graph points to http://localhost:8080/ci/view/All/job/MediaWiki-postgres-phpunit/.

Advice at https://issues.jenkins-ci.org/browse/JENKINS-13446 was that this is "likely" a misconfiguration on WMF's side and could be amended by setting "Jenkins URL" to "https://integration.mediawiki.org/ci" at https://integration.mediawiki.org/ci/configure.  If it isn't, please either follow up here or at Jenkins.

Version: unspecified
Severity: trivial

Details

Reference
bz35982

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:19 AM
bzimport set Reference to bz35982.
bzimport added a subscriber: Unknown Object (MLST).

Thanks. I'll then leave this bug here open until the issue has been resolved upstream.

Still there with Jenkins 1.472 and Dependency Graph 0.2.

Source code is on github at https://github.com/jenkinsci/depgraph-view-plugin The culprit is src/main/java/hudson/plugins/depgraph_view/DotStringGenerator.java which does the following:

private String projectToNodeString(AbstractProject<?, ?> proj) {

return escapeString(proj.getFullDisplayName()) +
        " [href=" +
        getEscapedProjectUrl(proj) + "]";

}

private String getEscapedProjectUrl(AbstractProject<?, ?> proj) {

return escapeString(Hudson.getInstance().getRootUrlFromRequest() + proj.getUrl());

}

getRootUrlFromRequest is most probably getting the URL based on whatever HTTP GET Jenkins received. In our setup, there is a proxy in front of Jenkins and hence any requests are made to 127.0.0.1:8080.

The plugin need to instead use whatever "Jenkins URL" is configured.

Our Apache conf makes https://integration.mediawiki.org/ci to be proxied to http://localhost:8080/ci

ProxyPass /ci http://localhost:8080/ci
ProxyPassReverse /ci http://localhost:8080/ci
ProxyRequests Off

<Proxy http://localhost:8080/ci*>

Order deny,allow
Allow from all

</Proxy>

I updated upstream bug : https://issues.jenkins-ci.org/browse/JENKINS-13446

Assigning to me so I can track the issue, fill free to takeover if needed.

Lowering priority since that is not really a trouble.

Moving bug back in the pool, just keeping CC:

apparently solved on Nov 13th by version 0.5

(In reply to comment #7)

apparently solved on Nov 13th by version 0.5

Hashar: Are there plans to deploy this Jenkins version?