Page MenuHomePhabricator

Graph format showing legend only if both graphcolor and graphlabel are set to "Yes"
Closed, ResolvedPublic

Description

Author: icarnevale

Description:
In SRF 1.7.1 when defining ask with parameter "format=graph", the graph legend is only shown when both parameters graphcolor and graphlabel are set to "Yes".
This is due to a logical "&&" in function getGVForDataValue of extensions/SemanticResultFormats/GraphViz/SRF_Graph.php:

if ( $this->m_graphLabel && $this->m_graphColor ) {

In older version (1.5.2) there were a logical "||"

if ( ( $this->m_graphLabel == true ) || ( $this->m_graphColor == true ) ) {

Trying to use "||" instead of "&&" the graph legend is shown, so this may be a possible solution.


Version: unspecified
Severity: normal

Details

Reference
bz36067