Page MenuHomePhabricator

Special:Version fails to render revision path links for svn extensions checked out with SVN 1.7
Closed, DeclinedPublic

Description

On my installation of MediaWiki core ( https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;h=d70e53ccd19b3b7040a42686b44cd44097b79973 ) and with mixed extensions from git and svn, a first extension from SVN (APC) is rendered with their revision as link, but all other svn extension revisions are not rendered as links.

"r123456" numbers are shown, but not rendered as link.


Version: 1.20.x
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43986

Details

Reference
bz36224

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36224.
bzimport added a subscriber: Unknown Object (MLST).

I found that the links are not shown for such extensions which were checked out as developer.

"r123456" are shown as links (as they were shown in former MediaWiki versions) only for anonymously checked out extensions.

I imagine this is because with Subversion 1.7, .svn directories aren't in all the subdirectories. The difference of checking out from http vs. svn+ssh shouldn't make a difference at all, see SpecialVersion::$viewvcUrls

(In reply to comment #4)

I imagine this is because with Subversion 1.7, .svn directories aren't in all
the subdirectories. The difference of checking out from http vs. svn+ssh
shouldn't make a difference at all, see SpecialVersion::$viewvcUrls

Indeed

Just swapped my dev wiki from HTTPS to svn+ssh and it's still working fine

But that is using SVN 1.6.12

The problem was not present in MediaWiki version before the move to git.

Do I understand correctly that this is only a problem when using 3rd party extensions that are hosted in some random SVN repository plus thoseextensions still left in deprecated Wikimedia SVN?
How common is that? Wondering if "normal" priority is accurate here...

Aklapper lowered the priority of this task from Medium to Lowest.Feb 16 2015, 11:34 AM
Aklapper set Security to None.