Page MenuHomePhabricator

Edit tools and Narayam not working in gujarati wikis (IE7)
Closed, ResolvedPublic

Description

screenshot showing missing edit tools and Narayam

When working in IE7, edit tools and Narayam are not working in gujarati wikipedia and wikisource. It always worked until last week for wikisource and until yesterday on wikipedia. This is a showstopper for users who are somehow unable to upgrade their browser, like myself, I work from my work place, and due to software policies I can't use Firefox or upgrade my browser.

Moreover, if it worked until yesterday, should work now as well.

Operating system: XP-Service pack 2
IE version: 7


Version: master
Severity: critical
OS: Windows XP
Platform: PC

Attached:

wikisource-IE7-XP-SP2.JPG (768×1 px, 137 KB)

Details

Reference
bz36275

Event Timeline

WFM on Ubuntu Chrome/Firefox.

Not sure if its an IE specific regression due to 1.20wmf1

Srikanthlogic: I tried translatewiki.net and both the things are missing there as well. Will appreciate if someone could look into this at the earliest.

I consider it as Highly important as well. As confirmed on IRC last night, the issue is with IE7, as it works well in IE9.

I had a check with IE8 and it works there as well. Am not sure if its just WikiEditor / Narayam or any other javascript based extensions / scripts that are broken on IE7. (WebFonts work as I see from screenshot) This certainly appears to be 1.20wmf1 regression.

Srikanth: The error explanation reads as below-

Line: 5
Character: 725
Error: Expected identifier, string or number
Code: 0
URL: (Url of the page)

Wild guess after a google search. Could http://blog.favrik.com/2007/11/29/ie7-error-expected-identifier-string-or-number/ be the issue? In which case we need to see which js had the extra comma between 1.19 and 1.20wmf1 that caused this.

Adding debug=true to the url when testing could help by giving the file where the error is.

Srikanth: can you trigger the bug with IE8 or later in "compatibility mode"? That might be helpful.

Thanks Chris, Niklas for the tips. I used IE8 in compatibility mode, with and without setting debug=true. So there are multiple issues here.

  1. When I try with debug=true, I get the "mw is undefined". I remember seeing a bug existing for this, just couldnt get the number.
  1. "Expected identifier, string or number". Log shows WebFonts, Narayam js or their dependencies having some issue, although am not able to get why WikiEditor is also failing.
  • Log with debug=true on IE8 compatibility mode

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; InfoPath.2)
Timestamp: Fri, 11 May 2012 07:01:48 UTC

Message: 'mw' is undefined
Line: 1
Char: 1
Code: 0
URI: http://translatewiki.net/w/load.php?debug=true&lang=ta&modules=jquery.footHovzer&skin=vector&version=20120322T103859Z&*

  • Log without debug=true on IE8 compatibility mode

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; InfoPath.2)
Timestamp: Fri, 11 May 2012 07:02:28 UTC

Message: Expected identifier, string or number
Line: 16
Char: 658
Code: 0
URI: http://translatewiki.net/w/load.php?debug=false&lang=ta&modules=ext.translate%7Cext.webfonts.core%2Cinit%7Cjquery.client%2Ccookie%2CmessageBox%2CmwExtension%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.page.startup%7Cmediawiki.util&skin=vector&version=20120510T210043Z&*

Message: Expected identifier, string or number
Line: 11
Char: 727
Code: 0
URI: http://translatewiki.net/w/load.php?debug=false&lang=ta&modules=ext.gadget.HoverPopTools%2Cnoop%7Cext.kieli%2Cnarayam%7Cext.narayam.core%7Cext.narayam.core.contenteditable%7Cext.narayam.rules.ta%2Cta-99%2Cta-bamini%2Cta-inscript%7Cjquery.autoEllipsis%2CcheckboxShiftClick%2CcollapsibleTabs%2CdelayedBind%2ChighlightText%2ChoverIntent%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Csuggestions%2CtabIndex%2CtextSelection%7Cmediawiki.Uri%2Cuser%7Cmediawiki.legacy.mwsuggest%7Cmediawiki.page.ready&skin=vector&version=20120510T214528Z&*

Both have been merged.

Planning to push these fixes to WMF and TWN.

Even webfonts venished today... will be worth addressing that along with...

A fix for this will be deployed on Tuesday.

Thanks Siebrand, and any plans of including https://bugzilla.wikimedia.org/show_bug.cgi?id=35931 in tomorrow's deployment?