Page MenuHomePhabricator

[Regression] MySkin should be a very basic blank start
Closed, ResolvedPublic

Description

MySkin is, as I understand it, an attempt at a blank slate. However, it does include MediaWiki:common.css (and skins/common/commonPrint.css and skins/common/shared.css)

There is a suggestion that "redlinks" (a.new), viewed on MySkin, used to render in red. That would suggest to me that users using that particular skin used to be given skins/common/commonElements.css, which defines the redness of redlinks.

I can't believe that changing the display of a skin being used by people was intentional-more likely an unintentional side effect of tidying up CSS dependencies.

Could someone confirm?


Version: 1.20.x
Severity: blocker

Details

Reference
bz36276

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:26 AM
bzimport set Reference to bz36276.
bzimport added a subscriber: Unknown Object (MLST).

If this is indeed a bug, I suspect it is easy to fix.

In the mean time, could you provide more details? Can you be more specific in what you would expect the styles to be vs. what they are?

(In reply to comment #2)

In the mean time, could you provide more details? Can you be more specific in
what you would expect the styles to be vs. what they are?

On the VPT thread, the regular MySkin user reported that redlinks used to be red, but now are not (post 1.20wmf1 deploy). I suspect other bits of styling have also gone (the other things in commonElements.css), but that those changes have not yet been noticed because they are less obvious that redlinks.

Red links were forced by the preferences, but now no longer are. It seems new links are not currently defined in common and of course myskin does not have any styling for it itself, since it is purposefully 'unstyled'.

So adding a generic .new styling to common would solve it probably.

(In reply to comment #4)

So adding a generic .new styling to common would solve it probably.

Such a simple fix ... Could probably be done in time for 1.20 tarball.