improper links
Deployed to both test2 and http://www.mediawiki.org/wiki/Special:Version the Installed Extensions table has a missing column and improper link to gerrit. Compare to http://en.wikipedia.org/wiki/Special:Version
see screen shot
Version: 1.20.x
Severity: major
Attached:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T38465 MediaWiki bugs to be fixed for 1.20wmf2 deployment (tracking) | |||
| Resolved | • RobLa-WMF | T38361 Special:Version missing table column for Extension version, improper link |
(In reply to comment #0)
Seems ok on git HEAD locally, but on mw.org/test2wiki we get really strange
urls built/displayedmw.org:
<em>[<a class="external free"
href="https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CategoryTree.git;h=26661c3de371169c655d63e75a21afd2e8b01491">https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CategoryTree.git;h=26661c3de371169c655d63e75a21afd2e8b01491</a>
(26661c3)]</em>git head, locally:
<em><a rel="nofollow" class="external text"
href="https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CategoryTree.git;h=fa3fd8d51e07f177892fc2587e6be95114626741">(fa3fd8d)</a></em>Both should be ssh checkouts...
fenari:
var_dump( $wgExtensionCredits['specialpage'][0] );
array(6) {
["path"]=>
string(72) "/home/wikipedia/common/php-1.20wmf2/extensions/SiteMatrix/SiteMatrix.php"
["name"]=>
string(10) "SiteMatrix"
["author"]=>
array(4) {
[0]=>
string(12) "Tim Starling"
[1]=>
string(12) "Brion Vibber"
[2]=>
string(15) "Victor Vasiliev"
[3]=>
string(20) "Alexandre Emsenhuber"
}
["version"]=>
string(3) "1.1"
["url"]=>
string(51) "https://www.mediawiki.org/wiki/Extension:SiteMatrix"
["descriptionmsg"]=>
string(15) "sitematrix-desc"}
$sp = new SpecialVersion();
var_dump( $sp->getCreditsForExtension( $wgExtensionCredits['specialpage'][0] ) );
string(460) "<tr>
<td><em>[https://www.mediawiki.org/wiki/Extension:SiteMatrix SiteMatrix] <span class="mw-version-ext-version">(Version 1.1)</span></em></td> <td><em>[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675
(8fa26b1)]</em></td><td>Displays a [[Special:SiteMatrix|list of Wikimedia wikis]]</td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td> </tr>
"
Local:
var_dump( $wgExtensionCredits['specialpage'][5] );
array(6) {
["path"]=>
string(62) "/home/reedy/git/mediawiki/extensions/SiteMatrix/SiteMatrix.php"
["name"]=>
string(10) "SiteMatrix"
["author"]=>
array(4) {
[0]=>
string(12) "Tim Starling"
[1]=>
string(12) "Brion Vibber"
[2]=>
string(15) "Victor Vasiliev"
[3]=>
string(20) "Alexandre Emsenhuber"
}
["version"]=>
string(3) "1.1"
["url"]=>
string(51) "https://www.mediawiki.org/wiki/Extension:SiteMatrix"
["descriptionmsg"]=>
string(15) "sitematrix-desc"}
$sp = new SpecialVersion();
var_dump( $sp->getCreditsForExtension( $wgExtensionCredits['specialpage'][5] ) );
string(459) "<tr>
<td><em>[https://www.mediawiki.org/wiki/Extension:SiteMatrix SiteMatrix] <span class="mw-version-ext-version">(Version 1.1)</span></em></td>
<td><em>[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675 (8fa26b1)]</em></td><td>Displays a [[Special:SiteMatrix|list of Wikimedia wikis]]</td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td>
</tr>"
var_dump( $sp->getCreditsForExtension( $wgExtensionCredits['specialpage'][0] ) );
string(460) "<tr>
<td><em>[https://www.mediawiki.org/wiki/Extension:SiteMatrix SiteMatrix] <span class="mw-version-ext-version">(Version 1.1)</span></em></td> <td><em>[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675
(8fa26b1)]</em></td><td>Displays a [[Special:SiteMatrix|list of Wikimedia wikis]]</td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td> </tr>
"
<tr>
<td><em><a class="external text" href="https://www.mediawiki.org/wiki/Extension:SiteMatrix" title="">SiteMatrix</a> <span class="mw-version-ext-version">(Version 1.1)</span></em></td> <td><em>[<a class="external free" href="https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675">https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675</a>
(8fa26b1)]</em></td><td>Displays a <a href="/wiki/Special:SiteMatrix" title="Special:SiteMatrix">list of Wikimedia wikis</a></td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td> </tr>
var_dump( $sp->getCreditsForExtension( $wgExtensionCredits['specialpage'][5] ) );
string(459) "<tr>
<td><em>[https://www.mediawiki.org/wiki/Extension:SiteMatrix SiteMatrix] <span class="mw-version-ext-version">(Version 1.1)</span></em></td>
<td><em>[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675 (8fa26b1)]</em></td><td>Displays a [[Special:SiteMatrix|list of Wikimedia wikis]]</td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td>
</tr>"
<tr>
<td><em><a rel="nofollow" class="external text" href="https://www.mediawiki.org/wiki/Extension:SiteMatrix">SiteMatrix</a> <span class="mw-version-ext-version">(Version 1.1)</span></em></td>
<td><em><a rel="nofollow" class="external text" href="https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SiteMatrix.git;h=8fa26b1467c61c446738fb20bc1c7c2deed50675">(8fa26b1)</a></em></td>
<td>Displays a <a href="/wiki/Special:SiteMatrix" title="Special:SiteMatrix">list of Wikimedia wikis</a></td>
<td>Tim Starling, Brion Vibber, Victor Vasiliev and Alexandre Emsenhuber</td>
</tr>
Merged in wmf branch with https://gerrit.wikimedia.org/r/6368
I have deployed the commit on live site by cherry-picking commit ae12df0 on the local branch. Had to do that because there were some pending changes in 1.20wmf2 which were not synced on site. The local fork will autosolve on next 'git pull' :-D
Verified on test.wikipedia.org and then on https://www.mediawiki.org/wiki/Special:Version