Page MenuHomePhabricator

Validator 0.5.x does not work with Maps extension
Closed, ResolvedPublic

Description

Observed on translatewiki.net on page https://translatewiki.net/wiki/User:Siebrand. Pages with Maps on them do not load anymore.

Change window:
Update from: 978ab5b 2012-05-07 21:05:07 +0000
Updated to: cdc9e43 2012-05-08 09:05:06 +0000

Other observations:


Version: unspecified
Severity: blocker

Details

Reference
bz36631

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:20 AM
bzimport set Reference to bz36631.

Assigning to Jeroen, but as Validator development does not go through Gerrit, I no longer have an idea where to get an online commit list or diff list.

Damn, thought that my new stuff was working by now... this just shows the stuff really needs tests :)

Changes for all branches can be accessed via: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Validator.git

I will test more with the Maps extension. Till the issue has been resolved, you can always switch to 0.4.x branch.

I can now again gets maps on master. It's likely there are remaining issues though.

Just put twn back on master branch for Validator. So far, so good.

Oops. Too soon. This was observed. Not sure though where it comes from:

[09-May-2012 11:32:08] PHP Notice: Undefined property: IntParam::$negativesAllowed in /www/w/extensions/Validator/includes/definitions/IntParam.php on line 46
[09-May-2012 11:32:08] PHP Fatal error: Access to undeclared static property: Param::$accumulateParameterErrors in /www/w/extensions/Validator/includes/Param.php on line 297

This has been fixed I guess - you've not raged to me about it more, and this code now has tests :)