Page MenuHomePhabricator

magicLinkCallback does not support protocol-relative URLs
Closed, InvalidPublic

Description

The PMID magic link does not support a protocol-relative URL. For example:

PMID 12122621

Will always direct to http:// even when you are logged onto the secure server.

The RFC magic link does supports a protocol-relative URL.


Version: 1.20.x
Severity: normal

Details

Reference
bz36639

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:21 AM
bzimport set Reference to bz36639.
bzimport added a subscriber: Unknown Object (MLST).

PMID and RFC magic links (and others) are detected from the Parser::magicLinkCallback method.

The urls themselves are defined in interface messages:

Both the PMID and RFC messages are are set to protocol-relative urls

And testing it in a sandbox:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Shows that they are working fine.

Accessing it through the secure HTTPS server:
https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=534856

Also works. Please re-open if this is still a problem.

Krinkle: Your sandbox works for me.

But not on the English Wikipedia:

https://en.wikipedia.org/wiki/User:Gadget850/Bug_36639

I'd assume the change was not deployed there as yet.

I've requested the local change to be deleted on en.wikipedia.org.

Resolving this bug as INVALID since this is not a bug in the mediawiki software.

Thanks. Didn't know that was there.