Page MenuHomePhabricator

Add unit tests for InstantCommons and ForeignAPIRepo
Open, MediumPublic

Description

This functionality needs to be added to the MediaWiki core unit tests, as many use it to get images from Wikimedia Commons available in their wiki. See bug 36653 (T38653).


T38653: InstantCommons is broken

Details

Reference
bz36655

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36655.
bzimport added a subscriber: Unknown Object (MLST).

So do we want to have tests for instant commons (original request) or for ForeignAPIRepo (per Krinkle) ?

Is the brokeness caused by some bug in ForeignAPIRepo?

The recent breakage was caused by a bug in the central Http classes (almost no outgoing http requests were working at all, including those made by ForeignAPIRepo).

wgUseInstantCommons is just a shortcut for Setup.php to add a $wgForeignFileRepos using ForeignAPIRepo to link with http://commons.wikimedia.org/w/api.php

(In reply to comment #2)

The recent breakage was caused by a bug in the central Http classes (almost no
outgoing http requests were working at all, including those made by
ForeignAPIRepo).

We should introduce some sane tests for this then. The last versions were doing a bunch of external requests to sites we don't control.

(In reply to comment #1)

So do we want to have tests for instant commons (original request) or for
ForeignAPIRepo (per Krinkle) ?

Presumably the latter, but perhaps using Commons as the test repo.

  • Bug 41978 has been marked as a duplicate of this bug. ***
Krinkle renamed this task from Add unit tests for ForeignAPIRepo to Add unit tests for InstantCommons and ForeignAPIRepo .Jan 12 2017, 10:09 PM
Krinkle edited projects, added MediaWiki-File-management; removed MediaWiki-Core-Tests.
Krinkle updated the task description. (Show Details)
Krinkle removed a subscriber: wikibugs-l-list.
Aklapper renamed this task from Add unit tests for InstantCommons and ForeignAPIRepo to Add unit tests for InstantCommons and ForeignAPIRepo.Jan 17 2017, 1:28 PM