[SD] Add new parser function #drilldownlink
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	mwjames
	May 9 2012, 11:20 AM

Description

Patch has been made against SD SVN revision 115163

A patch which introduces a new parser function called #drilldown to enable links [2] pointing to Semantic Drilldown much like #formlink does in Semantic Forms.

Example

Parameter

category parameter is either empty, or specified through [cat=], [category=]
subcategory parameter is identified by either [subcat=] or [subcategory=]
filter parameters can be specified through [filter=Subject=Advertising&Keyword=Branding] or [filter=Subject=Advertising] [filter=Keyword=Branding]
[single] is a parameter identifier to achieve [1]
other supported parameters are [link text=], [tooltip=]

Notes

[1] http://www.mediawiki.org/wiki/SD#Removing_the_list_of_categories

Version: unspecified
Severity: enhancement

attachment SD-drilldown-parser-115163.patch ignored as obsolete

Details

Reference: bz36693

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:24 AM

• bzimport added a project: MediaWiki-extensions-SemanticDrilldown.

• bzimport set Reference to bz36693.

mwjames created this task.May 9 2012, 11:20 AM

Hi, thanks for this patch! SD has needed something like this for a long time.

The calls to array_merge_recursive_distinct() and http_build_query() seem like overkill here - are you sure they're needed? In the case of #formlink, they're used because #formlink allows arbitrary parameters (it adds them all to the query string) - #drilldown doesn't do that. And #formlink didn't use them until a few months ago:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php?r1=110324&r2=110685

Also, any objections to renaming this function to #drilldownlink? Or to changing the name of the parameter "filter" to "filters"?

That URL didn't display very well - let me try that again:

svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php?r1=110324&r2=110685

Version 2 of the patch related to #drilldownlink and changes

Changes are:

renamed parser function to #drilldownlink
renamed filter parameter to filters
replaced array_merge_recursive_distinct() with simple array_merge
for the time http_build_query() is kept to ensure the query string is correctly escaped

Changes have been tested against:

Attached:

SD-drilldown-parser-115163-v2.patch5 KBDownload

I just checked this in to the SD code on SVN, with some minor adjustments. I hope everything still works. And thanks again for the patch!

	F9382: SD-drilldown-parser-115163-v2.patch
	Nov 22 2014, 12:24 AM

[SD] Add new parser function #drilldownlinkClosed, ResolvedPublicActions