Page MenuHomePhabricator

"[X] This is a tool icon" showing on a random page
Closed, ResolvedPublic

Description

For some reason, "[X] This is a tool icon" has been showing on [[Compiler construction]] to logged out users.


Version: unspecified
Severity: minor
URL: https://en.wikipedia.org/wiki/Compiler_construction

Details

Reference
bz36968

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:23 AM
bzimport added a project: PageTriage.
bzimport set Reference to bz36968.
bzimport added a subscriber: Unknown Object (MLST).

Thehelpfulonewiki wrote:

I think I noticed this the other day too - but I can't quite remember what article I was on.

Thehelpfulonewiki wrote:

Bumping priority, more users seem to be experiencing the problem, adding a screenshot.

Thehelpfulonewiki wrote:

This is a tool icon bug

Attached:

this_is_a_tool_icon.png (955×1 px, 159 KB)

Screenshot

Bottom of the page:

<script type="text/javascript" src="bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&amp;lang=en&amp;modules=ext.pageTriage.external%2Cmodels%2Cutil%7Cext.pageTriage.views.toolbar%7Cjquery.spinner%7Cmediawiki.Title%2CjqueryMsg%2Clanguage&amp;skin=vector&amp;version=20120518T024428Z&amp;*"></script><script type="text/javascript" src="bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&amp;lang=en&amp;modules=ext.articleFeedback%7Cext.articleFeedback.ratingi18n%7Cjquery.appear%2CarticleFeedback%2Clocalize%2Ctipsy&amp;skin=vector&amp;version=20120518T024334Z&amp;*"></script><script type="text/javascript" src="//bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&amp;lang=en&amp;modules=jquery.ui.dialog%2Cdraggable%2Cmouse%2Cposition%2Cresizable&amp;skin=vector&amp;version=20120430T191410Z&amp;*"></script><div class="suggestions" style="top: 73px; width: 204px; display: none; left: auto; right: 28.8333px;"><div class="suggestions-results"></div><div class="suggestions-special"></div></div><div id="mwe-pt-toolbar">
<div id="mwe-pt-toolbar-close">

</div>
<div id="mwe-pt-toolbar-main">

		This is a tool icon.

</div>
</div>
<div id="mwe-pt-toolbar">
<div id="mwe-pt-toolbar-close">

</div>
<div id="mwe-pt-toolbar-main">

		This is a tool icon.

</div>
</div>

Attached:

This_is_a_tool_icon.png (497×852 px, 80 KB)

Yes, it seems to be inserted there by the ext.pageTriage.views.toolbar module.

Theoretically this shouldn't be possible since $wgPageTriageEnableCurationToolbar is currently set to false on en.wiki. Since no one is available to troubleshoot this today, I'm afraid I'll just have to turn off PageTriage for en.wiki until we can get to the bottom of it.

I just disabled the PageTriage extension on enwiki per request from Kaldari due to this bug.

Hi guys, thanks for reporting this bug.

I couldn't reproduce it on any of my platforms, in either logged in or logged out mode.

Could we get a bit more info about which page you were coming from when you experienced the bug?

Was it from the existing Special:NewPages page?
https://en.wikipedia.org/wiki/Special:NewPages

Or was it from the now-disabled New Pages Feed page?
https://en.wikipedia.org/wiki/Special:NewPagesFeed

Also, what browser version were you using? did you have any special gadgets or extensions loaded on your browser that might have caused this?

Thanks for helping us debug this issue, and sorry for any inconvenience.

I checked and it appeared that no matter what page I came from, the "[X] This is a tool icon" thing came up. My browser is google-chrome-stable 19.0.1084.46-r135956 (from the Ubuntu 11.04 Natty repository). I also tested it with firefox 12.0+build1-0ubuntu0.11.04.1. As I said in the report, this only happens when I'm logged out, so there were no gadgets. I have no extensions in either browser which would cause this.

Krenair: Have you ever visited the page Special:NewPagesFeed?

In theory, it should only show you that toolbar if:

  1. It is enabled on en.wiki (which it isn't)
  2. You are logged in and have the patrol right (which you didn't)
  3. The page was recently created (which it wasn't)
  4. You've visited Special:NewPagesFeed within the past 24 hours

Clearly something is wrong here, but I'm not sure what, as I haven't been able to reproduce the problem either. Every time I've visited one of the pages that people report the problem on, I haven't seen the toolbar.

Yes, I visited Special:NewPagesFeed within the last 24 hours.

I'm still leaning towards this being a caching issue, especially since it's only showing up for logged-out users and only on very obscure pages (that probably have very long cache lifespans).

I experienced it using Firefox on Windows, being logged-out, without having
visited Special:NewPages, and happening on pages seemingly at random (it
appeared on some pages, but not in others), but it happened at pages which were
not recently created, nor even edited.

Maybe it is some caching weirdness? Where is it determining to show it?

Thehelpfulonewiki wrote:

I visited it on Google Chrome Incognito Mode (19.0.1084.46) - there were a couple of users that came to #wikipedia on IRC as well to report the error, I don't imagine that they would have gone to Special:NewPagesFeed. Ryan - I have visited the New Pages Feed within the last 24 horus, and I am an admin so have the patrol right - but this error explicitly did *not* show up when I was logged in, only when I was logged out [Incognito Mode].

Since the extension is turned off completely now, if people continue to report it, we'll know it's definitely caching-related.

Actually this issue stopped when the extension was disabled.

We've turned the extension back on (with some minor tweaks), let me know if anyone reports seeing the bug again.