Page MenuHomePhabricator
Create Task
Maniphest T38975

Special pages with system messages having sections "==" show section "[edit]" links even when they cannot be edited
Closed, ResolvedPublic
Actions

Description

Special pages which usually cannot be edited (example: Special:Upload) with system messages which have sections "==" in it are rendered with section "[edit]" links. This does not make sense and should be repaired.

For example, when you modify [[MediaWiki:Uploadtext]] and change the line

+ To include a file in a page, use a link in one of the following forms:
to
+ == To include a file in a page, use a link in one of the following forms: ==

then the Special:Upload page is rendered with an "[edit]" link, which does not make sense.

In my view, System messages which are uneditable should never be rendered with section "[edit]" links.

Observed with https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;h=2f5914c2ce4c612920dd96f5ef66e3bd342d2195

Version: 1.20.x
Severity: trivial
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=6411

Details

Reference
bz36975

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:23 AM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz36975.
• bzimport added a subscriber: Unknown Object (MLST).
Wikinaut created this task.May 19 2012, 2:56 PM
Krenair added a comment.May 19 2012, 3:28 PM

Gerrit change 8016

Platonides added a comment.May 19 2012, 4:30 PM

Confirmed. Bisecting points to 7bfebad30875b852e1e70bde10dbd12fa3e8a673.
Something similar was reported at that time (r70498), but it wasn't
reproducible (and was indeed not shown in Wikipedia).

I don't see where it is affected, since special pages aren't articles nor use
the parser cache.
The only difference in the popts on both revisions is mIsPrintable changing
from NULL to false, a change which shouldn't matter.

Ok, the problem appeared because the this->mTitle->quickUserCan() was never
called, instead of being moved below. That block was then removed in r70499.

After r92703 (d70ad8c), it wouldn't be possible to show the edit markers,
since $popts->mEditSection would always be false.

But then r86304 (3a0ed7) replaced $wgOut->parse() with MessageCache->parse(),
which didn't have that provision.

Patched in https://gerrit.wikimedia.org/r/8017

IAlex added a comment.May 30 2012, 2:27 PM

Marking as fixed since the change is now merged.

duplicatebug added a comment.Oct 1 2012, 7:44 PM
  • Bug 17046 has been marked as a duplicate of this bug. ***
labster mentioned this in T141706: Skin:Erudite: Is method msgWikiNoEdit() still needed?.Jul 31 2016, 5:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL