Page MenuHomePhabricator

Special:Undelete on suppressed revisions
Closed, DuplicatePublic

Description

https://www.mediawiki.org/w/index.php?title=Special:Undelete&target=Uitest&timestamp=20120525212653

This revision was suppressed, but the text claims that the details can be found in the deletion log, and uses a broken deletion log link.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=19725

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:22 AM
bzimport set Reference to bz37120.

Thehelpfulonewiki wrote:

Hmm, marking as low, I don't think it's a big deal, the suppression log is oversight only for a reason - what do you suggest to fix this bug?

It's not a big deal which is why I marked it as minor. I'm aware that it's suppressionlog-only for a reason, but you're missing the point. This text is shown to people without the permission, tells them that details can be found in the wrong log, and gives a broken link to the log.

So, for users able to see normal deleted revisions: "This page revision has been suppressed."

Or, if the user has the supressionlog permission, "This page revision has been suppressed. Details can be found in the suppression log." with a link to the suppression log for the page which the revision was on instead of the suppression log for Special:Undelete.

Thehelpfulonewiki wrote:

Ok, so I confirmed that if the user is an oversighter, they see

One of the revisions of this diff has been suppressed. Details can be found in the suppression log. You can still view this diff if you wish to proceed.

Patch in Gerrit needs review...

Change 40283 had a related patch set uploaded by Nemo bis:
(bug 37120) Fix slightly broken behaviour with suppressed revisions on Special:Undelete

https://gerrit.wikimedia.org/r/40283

Change 40283 had a related patch set uploaded (by Alex Monk):
Fix slightly broken behaviour with suppressed revisions on Special:Undelete

https://gerrit.wikimedia.org/r/40283

Patch-For-Review

Aklapper subscribed.

@Krenair: Hi, I'm resetting the task assignee due to inactivity. Please feel free to reclaim this task if you plan to work on this - it would be welcome! Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for more information - thanks!

Change 40283 abandoned by Umherirrender:

[mediawiki/core@master] Suppression: Don't tell non-suppressor users to view a log if they can't

Reason:

Was fixed with I2440227b3e5a9b5baec81b57bb479ecc26052b27

https://gerrit.wikimedia.org/r/40283