Page MenuHomePhabricator

Language::factory(NULL) exception on SpecialBannerLoader
Closed, ResolvedPublic

Description

https://test.wikipedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail&notice=POTY+Test+Campaign+01

gives

Language::isValidBuiltInCode must be passed a string, NULL given

Backtrace:

#0 /home/wikipedia/common/php-1.20wmf4/languages/Language.php(188): Language::isValidBuiltInCode(NULL)
#1 /home/wikipedia/common/php-1.20wmf4/languages/Language.php(169): Language::newFromCode(NULL)
#2 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialBannerLoader.php(174): Language::factory(NULL)
#3 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialBannerLoader.php(109): SpecialBannerLoader->getMessage('centralnotice-t...')
#4 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialBannerLoader.php(98): SpecialBannerLoader->getNoticeTemplate()
#5 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialCentralNotice.php(1025): SpecialBannerLoader->getHtmlNotice('Banner1')
#6 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialCentralNotice.php(751): CentralNotice->assignedTemplatesForm('POTY Test Campa...')
#7 /home/wikipedia/common/php-1.20wmf4/extensions/CentralNotice/special/SpecialCentralNotice.php(46): CentralNotice->listNoticeDetail('POTY Test Campa...')
#8 /home/wikipedia/common/php-1.20wmf4/includes/SpecialPageFactory.php(493): CentralNotice->execute(NULL)
#9 /home/wikipedia/common/php-1.20wmf4/includes/Wiki.php(263): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#10 /home/wikipedia/common/php-1.20wmf4/includes/Wiki.php(592): MediaWiki->performRequest()
#11 /home/wikipedia/common/php-1.20wmf4/includes/Wiki.php(502): MediaWiki->main()
#12 /home/wikipedia/common/php-1.20wmf4/index.php(58): MediaWiki->run()
#13 /usr/local/apache/common-local/live-1.5/index.php(3): require('/home/wikipedia...')
#14 {main}

each time I click on a Campaign, I get such an error report.


Version: master
Severity: blocker

Details

Reference
bz37170

Event Timeline

https://gerrit.wikimedia.org/r/9210

Please leave this bug open until it is reviewed, merged and 1.20wmf4 updated (so that it blocks 1.20wmf4 tracker bug)