Page MenuHomePhabricator

Saved searches (shared by others) in Bugzilla sidebar are truncated and contain errors
Closed, ResolvedPublic

Description

The Wikimedia Bugzilla's sidebar is too small, and some text under the "Saved Searches" gets covered by the main body.

3 suggestions:

  1. Increase the width of the sidebar, so that its the same size as the normal wiki.
  2. Cut down the amount of text used.
  3. Get the text to respect the width of the sidebar, and go to a new line if necessary (like MediaWiki does).

Thanks :)


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61290

Details

Reference
bz37257

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:21 AM
bzimport set Reference to bz37257.

I've changed the bug summary of this bug from "Sidebar is too narrow" to "Saved searches in Bugzilla sidebar are truncated and contain errors".

Currently in the Bugzilla sidebar, there are a number of saved searches. However, (presumably) due to site CSS, they're cut off. For example, "0. Highest priority ‑ Ch" is how the first saved search reads. This probably just needs a width set on one of the HTML elements in the sidebar.

"0. Unprioritiesed, non‑" also contains a typo.

And I have no idea why "0." is being used (twice).

(In reply to comment #1)

Currently in the Bugzilla sidebar, there are a number of saved searches.
However, (presumably) due to site CSS, they're cut off. For example, "0.
Highest priority ‑ Ch" is how the first saved search reads. This probably just
needs a width set on one of the HTML elements in the sidebar.

Hmm, guess not. I poked at this briefly. This is the problematic code:

<a href="buglist.cgi?cmdtype=dorem&amp;remaction=run&amp;namedcmd=0.%20Highest%20priority%20-%20Check%20daily&amp;sharer_id=11475"
class="shared"
title="Shared by Mark A. Hershberger &lt;mah&#64;everybody.org&gt;"

0.&nbsp;Highest&nbsp;priority&nbsp;&#8209;&nbsp;Check&nbsp;daily

</a>

Non-breaking spaces are being forced for some reason.

Putting an e-mail address in the title attribute seems rather silly as well, but I suppose only logged-in users see these saved searches.

https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches enables you to choose whether they are displayed or not, however I lack understanding why Mark's saved searches are displayed by default for new users while others aren't.

Mark: Any idea (and time to fix typos)?

Problem only happens for shared saved searches.

Wild guess after reading the code (not tested):
In template/en/custom/global/search-links.html.tmpl, the line

[% q.name FILTER html FILTER no_break %]

should become

[% q.name FILTER html %]

Assumption was correct. I just tested this on http://boogs.wmflabs.org with two user accounts.

Change 82052 had a related patch set uploaded by Aklapper:
Saved searches with longer names shared by others in sidebar did not wrap

https://gerrit.wikimedia.org/r/82052

Change 82052 merged by Dzahn:
Saved searches with longer names shared by others in sidebar did not wrap

https://gerrit.wikimedia.org/r/82052