Page MenuHomePhabricator
Create Task
Maniphest T39362

Installer: Sidebar group separator should look like in Vector's sidebar
Closed, ResolvedPublic
Actions

Description

Code in includes/installer/WebInstallerOutput.php needs to be changed to output something with HTML structure closer to the real Vector sidebar. Please see the attachment.

Version: 1.19.0
Severity: minor
Whiteboard: gci2014

Details

Reference
bz37362
SubjectRepoBranchLines +/-
Fix group separator in installer's sidebarmediawiki/coremaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:28 AM
• bzimport added projects: Future-Release, MediaWiki-User-Interface, good first task.
• bzimport set Reference to bz37362.
• bzimport added a subscriber: Unknown Object (MLST).
Ara created this task.Jun 6 2012, 3:29 AM
Ara added a comment.Jun 6 2012, 3:30 AM

Image of Description

Attached:

K-20120606-429098.png (277×162 px, 17 KB)

Krinkle added a comment.Jun 6 2012, 2:11 PM

Small bug indeed. One line is good and one isn't.

Krinkle added a comment.Jun 6 2012, 2:12 PM

Confirmed on latest master.

matmarex added a comment.Nov 8 2014, 3:45 PM

Code in includes/installer/WebInstallerOutput.php needs to be changed to output something with HTML structure closer to the real sidebar.

Krinkle removed a project: Future-Release.Nov 25 2014, 9:13 PM
Nemo_bis updated the task description. (Show Details)Dec 1 2014, 7:27 AM
Nemo_bis set Security to None.
gerritbot added a project: Patch-For-Review.Dec 1 2014, 7:31 PM

Change 176721 had a related patch set uploaded (by M4tx):
Fix group separator in installer's sidebar

https://gerrit.wikimedia.org/r/176721

Patch-For-Review

matmarex added a comment.Dec 1 2014, 11:26 PM

GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5285447588642816

matmarex closed this task as Resolved.Dec 1 2014, 11:27 PM
matmarex assigned this task to m4tx.
matmarex edited projects, added MediaWiki-Installer, Vector (legacy skin); removed Patch-For-Review.
matmarex removed a subscriber: Unknown Object (MLST).
gerritbot added a comment.Dec 1 2014, 11:30 PM

Change 176721 merged by jenkins-bot:
Fix group separator in installer's sidebar

https://gerrit.wikimedia.org/r/176721

m4tx mentioned this in rMW6345e8aea553: Fix group separator in installer's sidebar.Dec 1 2014, 11:30 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 30 2016, 3:51 PM
• Phabricator_maintenance removed a parent task: T46881: [DO NOT USE] Vector skin issues (tracking) [superseded by #Vector].Jul 30 2016, 3:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL