Page MenuHomePhabricator

Autopromotion to autoreview doesn't always work
Closed, ResolvedPublic

Description

There is a report on de.wikipedia of a user (User:Eidni05), who meets all criteria for automatic promotion to autoreview, but hasn't been added to this group automatically [1].

You can compare the configuration [2] with the actual values manually:

  • days: 30 (user registered 2011-10-09T23:32:51Z, [5])
  • edits: 50 (I don't know which edit count is used, user_editcount is 325, [5])
  • spacing: 3, benchmark: 7 ([3]: 19:51, 11. Nov. 2011 - 17:42, 20. Nov. 2011 - 02:32, 28. Apr. 2012 - 20:17, 6. Mai 2012 - 18:24, 10. Mai 2012 - 19:29, 13. Mai 2012 - 20:34, 16. Mai 2012 - 22:33, 23. Mai 2012 - 13:36, 27. Mai 2012 - 15:48, 30. Mai 2012 - 23:13, 2. Jun. 2012 - 20:10, 7. Jun. 2012, so there are 11 edits with 3 days in between)
  • totalCheckedEdits: 50 (he has 91 edits in article namespace, all but 5 are flagged)
  • uniqueContentPages: 8 (definitely met, see e.g. edits on 24. may)
  • editComments: 20 (he seems to always use the summary in article namespace)
  • neverBlocked: true (yes [4])

But he is not in autoreview group ([5]).

Please check what's going wrong here and fix the autopromotion.

[1] https://de.wikipedia.org/w/index.php?title=Wikipedia_Diskussion%3AGesichtete_Versionen&diff=104138332&oldid=103720338
[2] https://noc.wikimedia.org/conf/highlight.php?file=flaggedrevs.php
[3] https://de.wikipedia.org/w/index.php?limit=500&tagfilter=&title=Spezial%3ABeitr%C3%A4ge&contribs=user&target=Eidni05&namespace=&tagfilter=&year=&month=-1
[4] https://de.wikipedia.org/w/index.php?title=Spezial:Logbuch/block&page=Benutzer%3AEidni05
[5] https://de.wikipedia.org/w/api.php?action=query&list=users&format=json&usprop=groups%7Cimplicitgroups%7Crights%7Ceditcount%7Cregistration&ususers=Eidni05


Version: unspecified
Severity: normal

Details

Reference
bz37403

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:21 AM
bzimport set Reference to bz37403.
bzimport added a subscriber: Unknown Object (MLST).

According to the DB, the user has 100 "content edits". The 'totalContentEdits' requirement is 150. From eval.php, lowering that requirement causes the user to be reported as able to get the right. So maybe there is a problem with 'totalCheckedEdits'.

reviewedEditsCheck() looks broken. $cutoff_unixtime is passed in as an amount but it is treated as a timestamp...

  • Bug 36357 has been marked as a duplicate of this bug. ***