Page MenuHomePhabricator

Can't show old revisions of Wikibase Items
Closed, ResolvedPublic

Description

The implementation of ItemViewAction doesn't support showing old revision, it always shows the newest.


Version: unspecified
Severity: enhancement
Whiteboard: storypoints: 2

Details

Reference
bz37681

Related Objects

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:29 AM
bzimport set Reference to bz37681.
bzimport added a subscriber: Unknown Object (MLST).

Using Article::view to implement ItemView would probably fix this, see bug #37682

This is very cool, thanks! Is there a way to get a header saying "this is an old version" or something? Open a new item or reopen this bug for that?

Actually, such a warning should be shown exactly if and when it's shown for wikitext pages... is that not the case?

Ah, note that the javascript editing stuff may hide or remove some things from the top of the page! Perhaps open a bug report for that, it needs more investigation.

Try to turn off JS and view an old revision.

I cannot reproduce your suggestion, i.e. switching of JavaScript does not bring the note back. Then again, right now the viewing an old item seems to be broken anyway -- is that due to the revert in the morning?

yes, the revert undid support for this. reopening.

Need tests once the dependencies are closed.

Verified in Wikidata demo time for sprint 8