Page MenuHomePhabricator

ItemViewAction should use Article::view
Closed, ResolvedPublic

Description

The ItemViewAction class should use an Article object, possibly with some methods overwritten, to show page content. Action::view implements a *lot* of functionality that is required when showing page content, is not yet supported for Items, and would be pointless and unmaintainable to re-implement. Here are a few things that would need to be addressed:

  • permission checks
  • showing old revisions and diffs
  • messing with the page title for the main page, etc
  • using the parser cache when appropriate
  • dealing with redirects

...and there's more.

We may need to modify the Article class a bit to make this work for us, e.g. by factoring out some functionality into methods that can easily be overwritten.


Version: unspecified
Severity: normal
Whiteboard: storypoints: 8

Details

Reference
bz37682

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:29 AM
bzimport set Reference to bz37682.

Things to check when implementing this:

  • do non-existing pages work as expected?
  • can blocked users see the page? (see 37961)
  • do blocked users see the edit features?
  • do users see the edit features if the page is protected?

Verified in Wikidata demo time for sprint 8