Don't show the blue 'Review' button on the New Pages Feed list if you are not an editor.
It's not relevant, and unfairly raises their expectations, since they cannot review that page with the curation bar anyway.
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T40055 New Pages Feed: Hide 'Review' button for non-editors | |||
| Resolved | Krinkle | T40151 Add support for getting and caching user rights in javascript |
To clarify a bit: The 'Review' button should only be shown to users with the patrol right, but we do want to show the 'Review' button on all articles in the queue regardless of whether they have already been reviewed or not.
I'd prefer it if the review button were *disabled* rather than hidden, with a hover stating why it's disabled.
I generally don't like interfaces that add and remove affordances. Grey it out, fine, but don't remove it entirely.
Thanks, Brandon. Your proposal works for me. If you haven't already, can you send a grayed-out version of the button to Kaldari, in case he doesn't have it?
bsitu wrote:
A new patch is submitted in here: https://gerrit.wikimedia.org/r/#/c/15854/