Page MenuHomePhabricator

Gerrit: Links containing git hash are broken
Closed, ResolvedPublic

Description

See gerrit 13558.

In the mail I received it says:

Krinkle has posted comments on this change.

Change subject: Link to CREDITS file on message 'version-poweredby-others'
......................................................................

Patch Set 1:

Interesting, they made exception for that in wmf-config:

https://gerrit.wikimedia.org/r/gitweb?p=operations/mediawiki-config.git;a=tree;f=live-1.5;h=9d9075e78c775d9fd24637e2eea1fdfe29a6fb1f;hb=HEAD

I suppose we can simply expect sites to make this work, and wmf will have to add the exception for CREDITS there, like for COPYING. Please do so before merging this commit, to avoid a 404 error.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45780

Details

Reference
bz38103

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:51 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz38103.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of bug 33437 ***
  • This bug has been marked as a duplicate of bug 17006 ***

Un-duping. Title seems confusing, what is the bug here?

We introduced this ourselves with bug 36774, but due to a bug in gerrit it also runs on hyperlinks. The other comment-link parsers don't interfere with each other, but their linkifier is independent from this.

(Quote bug 36774 comment #5)

[this] breaks links like

https://github.com/pediapress/mwlib/commit/4406d53b4c7dcd6cba8b7e5cf7076d08bf754f5c#docs/collection.rst

Filed http://code.google.com/p/gerrit/issues/detail?id=1451 upstream but in
fact we should tweak the regular expression a bit. Maybe replace \\b with \\s+
?

  • This bug has been marked as a duplicate of bug 36774 ***