Page MenuHomePhabricator

jquery.tablesorter should use .data() instead of .attr() for retrieving the (custom) sort-value
Closed, ResolvedPublic

Description

The data-sort-value attribute is used to pre-populate the data storage, but later modifications are only stored in the properties, not in the attributes.

Calling .data() will do the same as .attr(), except that .data() will be up to date if the value has changed.

Discovered when implementing bug 24950.


Version: 1.17.x
Severity: normal

Details

Reference
bz38152

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:54 AM
bzimport set Reference to bz38152.

That was done when .data() didn't yet exists.

Maybe, the unit tests written at the time use data() though.

Im fixing this now + unit test.

content hidden as private in Bugzilla