Page MenuHomePhabricator
Create Task
Maniphest T40218

Custom toolbar buttons location changes
Closed, DeclinedPublic
Actions

Description

Image of the changed toolbar buttons position

After the upgrade to mw1.19, the custom toolbar keeps switching positions from appearing correctly at the end of the regular toolbar to splitting the regular edit toolbar into two parts. Also the revised code for custom toolbar buttons doesn't work for me.

This happens on Wikimedia Commons and Wikipedia and most importantly on Wikisource, where most of my editing is done.

Recently, the positional change became more frequent, and I copied the source page code of both conditions, and created a .jpg image of both as they appear in Wikisource.

Version: 1.19.0
Severity: major
Whiteboard: aklapper-moreinfo

Attached:

Toolbar_layouts.jpg (136×1 px, 12 KB)

Details

Reference
bz38218

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:58 AM
• bzimport added projects: Browser-Support-Firefox, MediaWiki-JavaScript.
• bzimport set Reference to bz38218.
• bzimport added a subscriber: Unknown Object (MLST).
Ineuw created this task.Jul 6 2012, 4:53 PM
Ineuw added a comment.Jul 6 2012, 5:01 PM

Created attachment 10826
Source pages of both conditions copied from View Source page of Firefox

Additional file containing the Source pages of both conditions - with the correct toolbar position code on top, followed by the incorrect toolbar position code.

Attached:

Toolbar_buttons_source_page_codes.txt199 KBDownload

Ineuw added a comment.Aug 21 2012, 1:17 PM

The preamble: The wikisource editor environment is made up of two toolbar button sets.

The attached images display the first step of Wikimedia modifications to the "wikisource toolbar button layout" in wmf version 1.18f9. In this version the additional custom edit buttons added by users, which were always located at the end of the toolbar, have been inserted between the "wikisource specific" and the "wikimedia standard toolbar" buttons sets.

The 2nd step of the wikisource editor toolbar layout changes is reported in Bug 39367.

Aklapper added a comment.May 16 2013, 3:14 PM

Hi ineuw! Sorry that nobody has taken a look at this report yet and given feedback.

Which browser(s) and version does this happen with?
Can this be seen on a public Wikimedia wiki, or is this a private wiki? If private, which MediaWiki version do you run currently, and does this still happen?

TheDJ added a comment.Apr 7 2014, 4:28 PM

This is not part of the WikiEditor extension, but of core

Ineuw added a comment.Apr 7 2014, 4:48 PM

Please consider this bug report as closed as well.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL