Jenkins: Fail on BOM in submitted files
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	hashar
	Jul 7 2012, 6:15 PM

Description

We let BOM enter our repository which is definitely unwanted. Sam had to recently remove one in mediawiki/core https://gerrit.wikimedia.org/r/14622

Version: unspecified
Severity: enhancement

Details

Reference: bz38233

Related Objects
Search...

Status	Assigned	Task
Declined	None	T40233 Jenkins: Fail on BOM in submitted files
Declined	None	T101511 common job for all repositories that runs structural linting
Declined	None	T111181 use one job for all CI entry points

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:59 AM

• bzimport added a project: Continuous-Integration-Infrastructure.

• bzimport set Reference to bz38233.

• bzimport added a subscriber: Unknown Object (MLST).

hashar created this task.Jul 7 2012, 6:15 PM

This could be added to the linting job. We need a script to actually detect the BOM.

This is properly covered by the PHP_CodeSniffer rule "Generic.Files.ByteOrderMark" which we have in the MediaWiki standard.

Still have to get Jenkins to fail on phpcs checks which are non voter for now.

I don't think we should have a generic job that scans all files everywhere for a BOM. Instead let's defer this to individual linters or coding style checkers.

PHPCS has a sniff for it. So that's good.

Let's look into JSHint as well.

hashar lowered the priority of this task from Low to Lowest.Nov 24 2014, 11:54 AM

hashar set Security to None.

• demon unsubscribed.Dec 16 2014, 6:05 PM