Page MenuHomePhabricator

Language factory uses too simplistic caching
Closed, ResolvedPublic

Description

The language factory uses a caching scheme that basically breaks down for Wikibase because a lot of languages are requested all the time, often for a single page. Languages used should be cached, and kept for at least the duration of the present page rendering. Probably it is easier to just set the number of languages cached somewhat higher and use a simple purging of the oldest language on a list of most recently used ones.


Version: unspecified
Severity: enhancement

Details

Reference
bz38439

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:45 AM
bzimport set Reference to bz38439.
bzimport added a subscriber: Unknown Object (MLST).

Change Iee2c796a: Attempt on fixing the suicidal LangObjCache

The patch has been merged in 12/2012.

jeblad: Can this report be closed as RESOLVED FIXED? Or is this still an issue?

jeblad: Can you answer comment 2, please?

jeblad: Can you answer comment 2, please?

That is a partial fix, but the bug as it stand can be closed.