Page MenuHomePhabricator

Remove button for <big> from toolbar
Closed, DeclinedPublic

Description

In HTML5 <big> is deprecated, so I do not see any reason to have a button for it in the toolbar. The probably only reason why it is there is consistency with <small>, but since HTML5 isn't consistent in that point the toolbar needn't to be either.


Version: unspecified
Severity: normal
URL: http://www.w3.org/TR/2012/WD-html5-diff-20120329/#obsolete-elements

See also

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Instead of removing the button, its code could be changed to this:

'big': {
'labelMsg': 'wikieditor-toolbar-tool-big',
'type': 'button',
'icon': 'format-big.png',
'offset': [2, 2],
'action': {

		'type': 'encapsulate',
		'options': {
			'pre': "<span style=\"font-size: larger;\">",
			'periMsg': 'wikieditor-toolbar-tool-big-example',
			'post': "</span>"
		}

}

},

A gadget could try to do this until the bug is fixed, but

$( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
'section': 'advanced',
'group': 'size',
'tool': 'big'
} ).wikiEditor( 'addToToolbar', {
'section': 'advanced',
'group': 'size',
'tools': {

		'big': {
			'labelMsg': 'wikieditor-toolbar-tool-big',
			'type': 'button',
			'icon': 'format-big.png',
			'offset': [2, 2],
			'action': {
				'type': 'encapsulate',
				'options': {
					'pre': "<span style=\"font-size: larger;\">",
					'periMsg': 'wikieditor-toolbar-tool-big-example',
					'post': "</span>"
				}
			}
		}
        }

} );

would put the button in the wrong position...

(In reply to comment #2)

A gadget could try to do this until the bug is fixed

Here is another way:

// Workaround for [[bugzilla:38487]]
function fixBigButton(){

$( '.tool-button[rel=big]' )
  .off( 'click' )
  .on( 'click', function( e ){
    e.preventDefault();
    $( '#wpTextbox1' ).textSelection(
      'encapsulateSelection', {
        'pre': '<span style="font-size: larger;">',
        'peri': mw.msg( 'wikieditor-toolbar-tool-big-example' ),
        'post': '</span>'
      }
    );
  } );

}

if ( $.inArray( mw.config.get( 'wgAction' ), ['edit', 'submit'] ) !== -1 ) {

mw.loader.using( 'user.options', function () {
  if ( mw.user.options.get('usebetatoolbar') ) {
    mw.loader.using( [ 'jquery.textSelection', 'ext.wikiEditor.toolbar' ], function () {
      $( fixBigButton );
    } );
  }
} );

}

rahul14m93 wrote:

Gerrit Change #53010

Wikitext is not HTML. I'm not sure people actually want uglier wikitext.

(In reply to comment #5)

Wikitext is not HTML. I'm not sure people actually want uglier wikitext.

Indeed, this should probably be rejected: I suggest WONTFIX. (Sorry Rahul for the unclear status of this bug.)

For instance, I know some Wikimedia wikis where attempts at replacing simple markup with "more correct" HTML by bot were soundly and consistently rejected and forbidden. Wikis which want uglier wikitext can use Helder's solutions above, or bots.

rahul14m93 wrote:

(In reply to comment #6)

Its okay,i am happy to contribute in any form!

(In reply to comment #5)

[...] I'm not sure people actually want uglier wikitext.

My suggestion was to remove <big> completely, not to replace it with (I agree with you) ugly HTML. I can only see to reasons to user bigger font size than usual:

  • headlines, these should use == ... ==, not <big>
  • texts in other scripts that are hard to read in normal font size (like Arabic), these should have a lang="..." attribute, handle bidi correctly, etc. Adding some CSS to make them a bit bigger doesn't make things worse (it's inside a template in most cases anyway)

This seems to be not only my opinion: en.wikipedia adds a button for <small> to the old toolbar, but not one for <big> [1], the same is true for a gadget on de.wikipedia [2]

[1] [[MediaWiki:Common.js/edit.js]]
[2] [[de:Wikipedia:Helferlein/Extra-Editbuttons]]

Change 53010 abandoned by Bartosz Dziewoński:
(Bug 38487) Replaced the <big> with <span> in jquery.wikiEditor.toolbar.config.js

Reason:
Per consensus on the bug.

https://gerrit.wikimedia.org/r/53010

  • Bug 24488 has been marked as a duplicate of this bug. ***

On enwiki we replace <big> with the {{big}} template where appropriate. I have found instances where <big> should have never been used at all and the markup just needs to be removed.

{{big}} is defined as: <span style="font-size: 120%;">{{{1}}}</span>

Maybe it is possible for the parser to catch <big> in wikitext and render it as a <span> in HTML?
No ugly wikitext, no templates, faster parsing, better semantics.

He7d3r set Security to None.

I brought this up on the en.wiki village pump not knowing this was here. I think it would be a simple fix to use either {{big}} or the span style that it uses.

@Technical13 Well past Sunday, any word on how this is coming along (or not?) No hurry, just curious.

Sorry @EoRdE6, still trying to wrap my head around the consensus. It looks like the consensus is to just completely remove the ability to make text bigger. The alternative might be to add support for big tags as an xml object. Not sure if I want to do that either. Have to think about it a little more.

Bugreporter subscribed.

This user (Technical 13) is retired from Wikimedia. (feel free to reclaim it)

Danny_B raised the priority of this task from Low to Medium.Jan 22 2016, 3:51 PM
Danny_B added a project: good first task.

Change 271949 had a related patch set uploaded (by Haritha28):
Remove button <big> from toolbar

https://gerrit.wikimedia.org/r/271949

Change 340515 had a related patch set uploaded (by Amritsreekumar):
[mediawiki/extensions/WikiEditor] Remove button for <big> from toolbar

https://gerrit.wikimedia.org/r/340515

Change 340515 abandoned by Amritsreekumar:
Remove button for <big> from toolbar

https://gerrit.wikimedia.org/r/340515

Change 340518 had a related patch set uploaded (by Amritsreekumar):
[mediawiki/extensions/WikiEditor] Remove button for <big> from toolbar

https://gerrit.wikimedia.org/r/340518

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Mar 21 2017, 10:05 PM
Jdforrester-WMF subscribed.

Though <big> is not valid HTML it's valid wikitext. Re-writing <big>s in the parser into <span style…> is an option being considered in T154067 but whether or not that's done I don't think we're likely to want to do this any time soon. Maybe in another three or four years' time once TemplateStyles (or whatever) is everywhere.

Change 340518 abandoned by Jforrester:
Remove button for <big> from toolbar

Reason:
Sorry, have followed-up on the task explaining that this isn't appropriate to do now.

https://gerrit.wikimedia.org/r/340518

Change 271949 abandoned by Jforrester:
Remove button <big> from toolbar

Reason:
Sorry, have followed-up on the task explaining that this isn't appropriate to do now.

https://gerrit.wikimedia.org/r/271949

Dropping "Easy" because that implies that newbies should take on this task, which is grossly inappropriate. :-)

Perhelion changed the task status from Open to Stalled.Mar 30 2017, 9:11 AM

Perhelion changed the task status from "Open" to "Stalled".

How is this report stalled? What information is missing?

How is this report stalled? What information is missing?

Simply by information from @Jdforrester-WMF !?

I don't think we're likely to want to do this any time soon. Maybe in another three or four years' time once...

Change 271949 abandoned by Jforrester: ...this isn't appropriate to do now.

If I miss something you can correct me.

Ok. If your intention was to change the status to

Maybe in another three or four years' time

then, in absence of our traditional RESOLVED LATER, the relevant status is "declined".

This task does not meet the guidance in https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle for "Declined", as I am not vetoing it for all time as the product owner, I do not think it necessarily "contradicts a particular project's scope or the principles of the project", and I don't think either that "consensus that implementing [this request] would be a bad idea".

However, it clearly does meet the standard for "Stalled". Specifically, it is waiting for further input on a non-Phabricator task (review by the relevant product owner in a few years' time), as I mentioned, and cannot be acted upon until that happens.

Nemo, I know the "Stalled" status is a pet peeve of yours, but this attitude is not helpful. :-(

Not that this is an important button, but the general problem is, the Wiki syntax is intended to be a tag language and HTML developing is going straight to favor CSS. And so Wikimedia don't want CSS in syntax: T37704

So there is no real reason the remove such tags from Wiki syntax, compare the center tag, which is deprecated since over 20 years in HTML, but really widely used (in relation to deprecation, in some lesser strict Wikis, I self rreplaced hundreds of them).

Aklapper changed the task status from Stalled to Open.Nov 1 2020, 11:48 PM

I don't think we're likely to want to do this any time soon. Maybe in another three or four years' time once TemplateStyles (or whatever) is everywhere.

3½ years later, boldly unstalling. (Could potentially get be stalled again, after "review by the relevant product owner" - whoever that is.)

Any decision what is the proper solution to remove <big> from Mediawiki-generated HTML5 code?

If this is commonly used, it may be an opinion to either (1) change the button to add <span> or (2) automatically rewrite <big> in wikitext to <span> in MediaWiki.

Legoktm subscribed.

This was mostly discussed in the context of T154067, but my interpretation of the current consensus is that while <big> is deprecated in HTML, we are making an explicit choice to not consider it deprecated in wikitext and OK for editors to use. It has been more than the "three or four years" since T40487#3119873 (2017) and I don't think there is any interest in moving this forward. Certainly if people do want to remove it from the toolbar, that should be done on its own merits and not because it is obsolete in HTML (which is most of the discussion here).