Page MenuHomePhabricator

[Regression] jquery.ui.slider breaks IE9 on hewiki
Closed, DeclinedPublic

Description

problem is that the jquery.ui.slider creates a knob which is an anchor element, whose href is "#". this causes IE to jump to the top of the page as soon as one clicks on the knob in order to use the slider. this makes the slider practically unusable.

REPRODUCTION:

  1. create a wikipage, add enough lines to push current location so it's unvisible when you are at top of page.
  2. below this, create a new div, with class = "slidertest".
  3. create a script like so:
$(function() {
mw.loader.using('jquery.ui.slider', function() {
$('div.slidertest').slider(
{
			max: 150,
			min: 50,
			value: 77
});
});
});
  1. open the page in IE, and try to move the slider knob.
  2. note that you can move the slider knob in chrome and ff, but in ie, as soon as you click on it, the page jumps to the top.

WORKAROUND:
i do not have one - will be grateful for anything, even if it means adding some junk to my (clean and nice) scripts.

peace.


Version: 1.20.x
Severity: normal

Details

Reference
bz38500

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:49 AM
bzimport set Reference to bz38500.
bzimport added a subscriber: Unknown Object (MLST).

additional information:
tested on IE9. problem happens with "compatibility mode" both "On" and "Off".

apparently same problem does not occur on the page

http://jqueryui.com/demos/slider/

maybe it's newer version of jquery ui, but maybe we did something that actually caused the issue. can't debug ie very much.

Can't reproduce on current master.

I tested with BrowserStack on IE9 and tunnelled my localhost running the latest master.

seems to be happening on hewiki. can you please try it there? might be some problem stemming from interaction with an existing script there.

Tested with IE9 on hewiki, and got reproduced.

I only see hewiki mentioned here, so this might not be an issue in jquery but a local script/gadget/whatever interfering.

matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).

Our version of jquery ui is pretty old, and this issue is indeed fixed in newer versions.

Is there a blocking task that we could set? Something like "upgrade jQuery UI" or "get rid of jQuery UI", etc.

Jdforrester-WMF subscribed.

We've dropped IE9 from Grade A, so it no longer gets JavaScript.