Page MenuHomePhabricator

VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon)
Closed, ResolvedPublic

Description

This sounds to me like it might be hideously complicated, but putting it in here - e.g. a link to [http://foo.com] gets an external link notification icon on its right on the English Wikipedia, and this should show up as appropriate.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=33084
https://bugzilla.wikimedia.org/show_bug.cgi?id=37901

Details

Reference
bz38726

Related Objects

StatusSubtypeAssignedTask
OpenFeatureNone
ResolvedJdlrobson
ResolvedJdforrester-WMF
ResolvedArlolra
ResolvedEsanders
ResolvedCatrope
DeclinedNone
DeclinedNone
Resolvedssastry
Resolved bearND
Resolved bearND
Resolved bearND
Resolved bearND
OpenNone
Resolved Jhernandez
OpenNone
Resolved marcoil
ResolvedCatrope
Resolved marcoil
ResolvedArlolra
ResolvedArlolra
Resolved GWicke
Resolved GWicke
Resolved GWicke
Resolvedfgiunchedi
Resolvedfgiunchedi
Resolved Cmjohnson
Resolved Cmjohnson
ResolvedJoe
Resolvedfgiunchedi
Resolved GWicke
Resolved Jdouglas
Resolved GWicke
Resolved GWicke
ResolvedArlolra
Resolved GWicke
Resolved mobrovac
Resolved mobrovac
Resolved mobrovac
Resolved mobrovac
Duplicate Jdouglas
ResolvedAndrew
Resolved GWicke
Resolvedfgiunchedi
Resolvedfgiunchedi
Resolvedfgiunchedi
ResolvedEevans
Resolvedfgiunchedi
Resolved GWicke
Resolved GWicke
Resolvedfgiunchedi
Resolved mobrovac
Resolved GWicke
Resolved GWicke
Resolved AlexMonk-WMF
Resolved santhosh
Resolvedssastry
Resolved Mholloway
ResolvedJackmcbarn
ResolvedRenxiaoyi
Resolvedcscott
ResolvedKelson
OpenNone
OpenNone
OpenNone
ResolvedArlolra
ResolvedArlolra
OpenNone
DeclinedNone
OpenNone
OpenNone
DeclinedNone
DeclinedNone
DeclinedNone
OpenNone
OpenNone
InvalidNone
InvalidNone
DuplicateNone
DuplicateNone
Resolved Jhernandez
ResolvedJdlrobson
DuplicatePeter
Resolved bmansurov
DeclinedNone
DuplicateNone
Resolved nray
Resolvedphuedx
ResolvedAnomie
ResolvedAnomie
ResolvedAnomie
ResolvedEBernhardson
ResolvedAnomie
ResolvedAnomie
OpenNone
DuplicateNone
ResolvedNone
Resolvedphuedx
DeclinedNone
Resolved Pchelolo
ResolvedArlolra

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:04 AM
bzimport set Reference to bz38726.

Applying the same CSS may be difficult, but internal vs external links should be rendered differently somehow.

Change 130769 had a related patch set uploaded by Jforrester:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769

Change 130769 merged by jenkins-bot:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769

Verified the fix in Betalabs and test2

Verified the fix in production

I'm not seeing this as entirely fixed. The redlink issue has been fixed but there are still other colour issues:

  • Visited redlinks are not shown in the visited redlink colour, they are shown in the redlink colour.
  • External links are not shown in the external links colour, they are shown in the internal links colour.
  • Link icons are omitted: external, secure, pdf etc.

The raison d'etre of VE is that it is WYSIWYG while editing. Not having links in the right colour defeats this and can lead to mistakes.

(In reply to Spinningspark from comment #6)

I'm not seeing this as entirely fixed. The redlink issue has been fixed but
there are still other colour issues:

  • Visited redlinks are not shown in the visited redlink colour, they are

shown in the redlink colour.

  • External links are not shown in the external links colour, they are shown

in the internal links colour.

  • Link icons are omitted: external, secure, pdf etc.

This caught my attention because external link icons have been working for me for a while. Turns out they work in Vector but not in Monobook. This appears to be a bug in Monobook, it's scoping link icon CSS to the wrong div (#bodyContent instead of #content).

Change 153740 had a related patch set uploaded by Catrope:
Scope external link styling rules to #content rather than #bodyContent

https://gerrit.wikimedia.org/r/153740

Change 153740 abandoned by Catrope:
Scope external link styling rules to #content rather than #bodyContent

Reason:
Yeah, that looks much better, thanks guys.

https://gerrit.wikimedia.org/r/153740

Change 151395 had a related patch set uploaded by Jforrester:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395

Change 151395 merged by jenkins-bot:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395

Marking this back as FIXED (as it has been fixed in Vector for a while).