Page MenuHomePhabricator

Use my current location hangs on areas with few/no monuments
Closed, ResolvedPublic

Description

When clicking on use my current location in a location where there are few or no monuments (for example Sydney) the map is never loaded. This is due to the fix for bug 38741.

Essentially what happens is the map continues to zoom out from zoom level 18 until it finds monuments. When it gets to zoom <11 the api fails to respond possibly due to a throttling constraint the server imposes (as the client at this point would have made about 7 requests).

Possibly we want to give up looking at zoom level 10 to prevent this but I suspect the server needs to do something more useful such as refuse requests when such throttling occurs.

You can demonstrate this by running
WLMMobile.app.showMonumentsForPosition(-33.859972, 151.211111)
in your console (you will need to expose showMonumentsForPosition in app.js


Version: unspecified
Severity: normal

Details

Reference
bz38983

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:53 AM
bzimport set Reference to bz38983.
bzimport added a subscriber: Unknown Object (MLST).

Querying an arbitrarily large area is not supported. Because the API installation on TS is also used for stuff other than app, search area restriction is not enforced. However, the standalone API will simply return an error for areas larger than 0.2 x 0.2 degrees (discussable) - the app should enforce this restriction internally.