Maniphest T41025

Gadgets 2.0: "hidden" doesn't work
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	He7d3r
	Aug 4 2012, 12:52 AM

Tags

Referenced Files

None

Subscribers

View All 10 Subscribers

Description

From
https://www.mediawiki.org/wiki/Thread:Talk:ResourceLoader/V2_testing/Unable_to_hide_a_gadget

The "hidden" option is not working for this gadget[1]. It appears on [2] even after I hide it[3]. Indeed, the loop[4] which adds a preference for each gadget doesn't check for its hidden property before adding it to Special:Preferences (BTW: it also doesn't check if the user has the appropriate rights).

[1] http://rl2.wmflabs.org/rl2-repo1/wiki/Gadget_definition:test.js
[2] http://rl2.wmflabs.org/rl2-repo1/wiki/Special:Preferences#mw-prefsection-gadgets Special:Preferences#mw-prefsection-gadgets
[3] http://rl2.wmflabs.org/rl2-repo1/w/index.php?title=Gadget_definition:test.js&diff=prev&oldid=462
[4] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Gadgets.git;a=blob;f=Gadgets.hooks.php;hb=refs/heads/RL2#l305

Details

Reference: bz39025

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T34169 Action to join scripts and styles in one file
		Open		None	T110014 Make gadgets easily customizable (merge Gadgets' branch "gadgetprefs" from GSoC 2011)
		Open		None	T31272 Implement Gadgets 2.0
		Resolved		kaldari	T41025 Gadgets 2.0: "hidden" doesn't work

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:56 AM

• bzimport added a project: MediaWiki-extensions-Gadgets.

• bzimport set Reference to bz39025.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Aug 4 2012, 12:52 AM

Confirming that this bug is still present.

Ricordisamoa subscribed.Jul 23 2015, 5:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2015, 5:48 PM

PeterBowman subscribed.Jul 29 2015, 11:07 PM

MGChecker subscribed.Oct 30 2015, 10:30 AM

Luke081515 subscribed.Oct 31 2015, 4:44 PM

For CommTech: We should test this after these tickets are done:

T106177: Implement Gadget and Gadget definition namespaces plus their content models
T31398: Implement Gadget Manager

Legoktm expects that this is already fixed; we just need to make sure, and close the ticket.

• DannyH moved this task from New & TBD Tickets to Bug backlog on the Community-Tech board.Nov 5 2015, 10:37 PM

Catrope unsubscribed.Nov 13 2015, 8:06 PM

• DannyH added a project: WikiProject-tools.Dec 7 2015, 5:56 PM

He7d3r updated the task description. (Show Details)Jan 6 2016, 9:25 PM

He7d3r removed a subscriber: • wikibugs-l-list.

kaldari raised the priority of this task from Low to Medium.Feb 2 2016, 6:19 PM

kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.

kaldari edited a custom field.

Confirmed fixed on http://commtech.wmflabs.org (which is running the code at https://gerrit.wikimedia.org/r/#/c/247869/)

kaldari moved this task from Ready to Q3 2018-19 on the Community-Tech-Sprint board.Feb 2 2016, 9:04 PM

• DannyH moved this task from Q3 2018-19 to Q1 2018-19 on the Community-Tech-Sprint board.Feb 4 2016, 1:34 AM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Feb 17 2016, 1:38 AM

• DannyH moved this task from Bug backlog to Archive on the Community-Tech board.

Krinkle mentioned this in T33150: Implement "hidden" gadget feature (pre-Gadgets 2.0).Nov 18 2016, 4:21 AM