Page MenuHomePhabricator

Incomplete i18n for log entries in CentralAuth
Open, LowPublic

Description

[1] for example reads like this in Dutch:

3 aug 2012 09:47 MarcoAurelio (Overleg | bijdragen) heeft de status voor de globale gebruiker User:Kanakane28@global gewijzigd. Ingesteld: *locked*; verwijderd: *(none)* (Spam-only account: spambot)

Texts within *these areas*, marked by me, could be localised. This requires updating the logging of CentralAuth, keeping BC in place.

[1] https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=globalauth&user=MarcoAurelio&uselang=nl


URL: https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=globalauth&user=MarcoAurelio&uselang=nl

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:57 AM
bzimport set Reference to bz39045.
bzimport added a subscriber: Unknown Object (MLST).

These texts are localised by translatewiki.net (e.g. centralauth-log-status-locked) but the code uses wfMsgForContent(...) when create the log entry.

It is not much work to change the code but I think the author has made his thoughts about using wfMsgForContent() instead of wfMsg(). Should we change this?

(In reply to comment #1)

It is not much work to change the code but I think the author has made his
thoughts about using wfMsgForContent() instead of wfMsg(). Should we change
this?

That would log in the performer's user language and make even more o a mess, as the log entries would display in multiple languages.

The information should be stored in extra parameters for the log entry, and i18ned when displaying it (as opposed to save time).

(In reply to comment #2)

(In reply to comment #1)

It is not much work to change the code but I think the author has made his
thoughts about using wfMsgForContent() instead of wfMsg(). Should we change
this?

That would log in the performer's user language and make even more o a mess, as
the log entries would display in multiple languages.

Per Siebrand. That happened in the past and was a complete dissaster. CentralAuth logs showed in the language of the performer. Please don't do that.

Maybe the changes in [[gerrit:38137]] can help here?

(In reply to comment #6)

Maybe the changes in [[gerrit:38137]] can help here?

It won't hurt, but doesn't solve. https://www.mediawiki.org/wiki/Logging_to_Special:Log#1.19_and_later needs to be applied.

Change 609298 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system

https://gerrit.wikimedia.org/r/609298

Change 737165 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (part 1)

https://gerrit.wikimedia.org/r/737165

Change 737165 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (part 1)

https://gerrit.wikimedia.org/r/737165

Change 737168 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (part 2)

https://gerrit.wikimedia.org/r/737168

Change 737168 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (part 2)

https://gerrit.wikimedia.org/r/737168

Change 609298 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (part 3)

https://gerrit.wikimedia.org/r/609298

Change 746009 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/CentralAuth@master] Migrate to modern logging system (last part)

https://gerrit.wikimedia.org/r/746009