Page MenuHomePhabricator

jquery.wikiEditor.dialogs: 'missing' and 'invalid' properties should check against undefined instead of truthy
Closed, ResolvedPublic

Description

See module's code at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikiEditor.git;a=blob;f=modules/jquery.wikiEditor.dialogs.config.js;h=76a3a57e27b6b7d87266171c26baf2a82d9f703a;hb=e7a0484eb56d72e5326282a54288580fdfcd144f

The if conditions at lines 201 and 203 must probably be corrected.

from : if ( page.missing )
to : if ( page.missing !== undefined )

and

from : if ( page.invalid )
to : if ( page.invalid !== undefined )

This code checks the api query result,
which, for instance, has

page.missing === ""

if queried title doesn't exist.

As it is, the "Insert link" dialog shows "Page exists"
for every title inserted in the "Target page or URL:" field.


Version: unspecified
Severity: normal

Details

Reference
bz39091

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:00 AM
bzimport set Reference to bz39091.

(In reply to comment #0)

Sorry for the link. I split the server part, so that could be read.

https://gerrit.wikimedia.org

/r/gitweb?p=mediawiki/extensions/WikiEditor.git;a=blob;f=modules/jquery.wikiEditor.dialogs.config.js;h=76a3a57e27b6b7d87266171c26baf2a82d9f703a;hb=e7a0484eb56d72e5326282a54288580fdfcd144f

We also encountered this bug in the VisualEditor.

Assigning to Rob who already fixed this in VisualEditor, we should be able to
apply the same fix to WikiEditor.

This has already been fixed and was merged in July 31st.
https://gerrit.wikimedia.org/r/#/c/17019/

Thank you!

Next time, I'll try to search a bit more, before entering a bug.