Page MenuHomePhabricator

autoComment functionality needs tests for each Wikibase API module
Closed, InvalidPublic

Description

The Autocomment class has generic tests, but each unit test for an API module should also check whether each API operation results in the correct autoComment being logged to the revision table.


Version: master
Severity: normal
Whiteboard: u=dev c=QA p=0

Details

Reference
bz39131

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:03 AM
bzimport set Reference to bz39131.
bzimport added a subscriber: Unknown Object (MLST).

Adam, can you tell us what the status of this is? Perhaps it would be enough to test the summaries generated by ChangeOps?

currently summaries are tested for some api modules, toher have no tests for summaries.

An example of the current style of test for summary we have can be seen at

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/tests/phpunit/includes/api/EditEntityTest.php#L263

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).