Page MenuHomePhabricator

Translate links should be protocol-relative; avoid red links
Closed, ResolvedPublic

Description

The link to the translate page on my user talk page is not protocol-relative, thus I made several edits without being logged in before realizing that.

Also, the link to the translatable page does not use the [[m:]] prefix, so it is a red link to the local wiki.

Both can be seen on my user talk on nowiki: https://no.wikipedia.org/wiki/Brukerdiskusjon:Jon_Harald_S%C3%B8by#Oversettelsesvarsel

(I would love to (try and) fix this myself, but can't get Gerrit to work. Can you point me to a good guide?)


Version: unspecified
Severity: normal
URL: https://no.wikipedia.org/wiki/Brukerdiskusjon:Jon_Harald_S%C3%B8by#Oversettelsesvarsel

Details

Reference
bz39139

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:03 AM
bzimport set Reference to bz39139.
bzimport added a subscriber: Unknown Object (MLST).

(bump)
The part about the [[m:]] prefix has been solved, but the protocol-relativity is still an issue. It should be easy to fix, just change instances of http:// to // (but of course you know that).

And again, I can't be bothered to try Gerrit.

  • Bug 45185 has been marked as a duplicate of this bug. ***

I agree that protocol-relative links should be used in the talk pages notifications. A translator from China pointed this out as a security issue to me (https://meta.wikimedia.org/w/index.php?diff=4822644&oldid=4502873 ).

Obviously, protocol-relative links usually won't work in the email notifications; it would be nice to use HTTPS for those by default.

Change 84849 had a related patch set uploaded by Siebrand:
Allow always using https links in emails

https://gerrit.wikimedia.org/r/84849

Patch has been waiting for review for close to 3 weeks.

Patch has been waiting for merge for 6 weeks now. It was +1-ed 2 weeks ago by Legoktm.

Change 84849 abandoned by Siebrand:
Allow always using HTTPS links in emails

Reason:
No reviewers in

https://gerrit.wikimedia.org/r/84849

I abandoned the patch set. I've tried everything to get the code reviewed, but wasn't able to in two months. Needed to clean up my gerrit dashboard.

I understand that you need to cleanup your dashboard, yet I don't see a reason why that change needs to be abandoned. Can you assign it to me? I don't mind having it on my dashboard. Would you mind if I checkout that change, create a different branch and store it there, and wait for someone to review?

Change 84849 restored by Amire80:
Allow always using HTTPS links in emails

Reason:
The code is valid for review, it just waited too long.

https://gerrit.wikimedia.org/r/84849

Change 84849 merged by jenkins-bot:
Allow always using HTTPS links in emails

https://gerrit.wikimedia.org/r/84849