Page MenuHomePhabricator

wbgetitems to return revid
Closed, ResolvedPublic

Description

When calling the wbgetitems module the result should also contain the revision id in the content for every given item.


Version: unspecified
Severity: trivial
Whiteboard: storypoints: 2
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=39141
https://bugzilla.wikimedia.org/show_bug.cgi?id=39329

Details

Reference
bz39140

Related Objects

StatusSubtypeAssignedTask
DeclinedLydia_Pintscher
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:03 AM
bzimport set Reference to bz39140.
bzimport added a subscriber: Unknown Object (MLST).

The revid attribute will be inlined with the item on wbgetitems, i.e.

item : {

350: {
   id : 350,
   revid : 2000,
   sitelinks : ...
)

}

This seems to be called "lastrevid" in the rest of the API, using this name to be consistent. Can't see any pros and cons in any direction, except for being consistent.

Included as default if props are not redefined, and will then be added together with a few other bits of information. This is basically the same as the ordinary query module is returning. The field "revid" is called "lastrevid" to be consistent with the this module.

https://gerrit.wikimedia.org/r/18463

Note that the ordinary id for the item is returned unconditionally as it should be possible to use "props=" to create a lightweight query. It could be argued that lastrevid should also be returned unconditionally.

Verified in Wikidata demo time for sprint 12